[v4,0/4] Introduce EBBG FT8719 DRM panel driver

Message

Joel Selvaraj June 1, 2022, 8:24 a.m. UTC

Add bindings and DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI
video mode panel, which can be found on some Xiaomi Poco F1 phones.
The panel's backlight is managed through QCOM WLED driver.

The driver is built using linux-mdss-dsi-panel-driver-generator[1], and
additionally support for handling regulators and linking external
backlight is added.

[1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator

Changes in v4: (Linus Walleij's Suggestion)
 - Introduce mipi_dsi_dcs_write_seq macro in include/drm/drm_mipi_dsi.h
 - Remove the driver specific dsi_dcs_write_seq macro
 - Use the newly introduced mipi_dsi_dcs_write_seq macro instead

Changes in v3: (Mostly Linus Walleij's Suggestions)
 - Removed ctx->prepared state variable as it's handled by the core
 - Print error in dsi_dcs_write_seq macro if it fails to write
 - Removed magic power on sequences as panel works fine without them

Changes in v2: (Krzysztof Kozlowski's Suggestions)
 - dt-bindings: specify maxItems for reg
 - dt-bindings: cleanup and simplify the panel properties
 - dt-bindings: in example change "|+" to "|' and "dsi0" to "dsi"

Joel Selvaraj (4):
  dt-bindings: vendor-prefixes: Add prefix for EBBG
  dt-bindings: display: Add bindings for EBBG FT8719
  drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro
  drm/panel: introduce ebbg,ft8719 panel

 .../bindings/display/panel/ebbg,ft8719.yaml   |  74 +++++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   7 +
 drivers/gpu/drm/panel/Kconfig                 |  11 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-ebbg-ft8719.c     | 285 ++++++++++++++++++
 include/drm/drm_mipi_dsi.h                    |  17 ++
 7 files changed, 397 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-ebbg-ft8719.c

Comments

Sam Ravnborg June 24, 2022, 8:37 p.m. UTC | #1

Hi Joel,

On Wed, Jun 01, 2022 at 01:54:06PM +0530, Joel Selvaraj wrote:
> Add bindings and DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI
> video mode panel, which can be found on some Xiaomi Poco F1 phones.
> The panel's backlight is managed through QCOM WLED driver.
> 
> The driver is built using linux-mdss-dsi-panel-driver-generator[1], and
> additionally support for handling regulators and linking external
> backlight is added.
> 
> [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator
> 
> Changes in v4: (Linus Walleij's Suggestion)
>  - Introduce mipi_dsi_dcs_write_seq macro in include/drm/drm_mipi_dsi.h
>  - Remove the driver specific dsi_dcs_write_seq macro
>  - Use the newly introduced mipi_dsi_dcs_write_seq macro instead
> 
> Changes in v3: (Mostly Linus Walleij's Suggestions)
>  - Removed ctx->prepared state variable as it's handled by the core
>  - Print error in dsi_dcs_write_seq macro if it fails to write
>  - Removed magic power on sequences as panel works fine without them
> 
> Changes in v2: (Krzysztof Kozlowski's Suggestions)
>  - dt-bindings: specify maxItems for reg
>  - dt-bindings: cleanup and simplify the panel properties
>  - dt-bindings: in example change "|+" to "|' and "dsi0" to "dsi"
> 
> Joel Selvaraj (4):
>   dt-bindings: vendor-prefixes: Add prefix for EBBG
>   dt-bindings: display: Add bindings for EBBG FT8719
>   drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro
>   drm/panel: introduce ebbg,ft8719 panel

All applied to drm-misc (drm-misc-next), thanks!

	Sam