diff mbox series

monitor: Fix crash when using RTT backend

Message ID 20220624082541.51687-1-szymon.janc@codecoup.pl (mailing list archive)
State Accepted
Commit 1d6cfb8e625a944010956714c1802bc1e1fc6c4f
Headers show
Series monitor: Fix crash when using RTT backend | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS

Commit Message

Szymon Janc June 24, 2022, 8:25 a.m. UTC
This fix regression introduced by "monitor: Fix memory leaks".
J-Link shared library is in use if jlink_init() returns 0 and thus
handle shall not be closed.
---
 monitor/jlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com June 24, 2022, 9:29 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=653494

---Test result---

Test Summary:
CheckPatch                    PASS      1.09 seconds
GitLint                       PASS      0.73 seconds
Prep - Setup ELL              PASS      43.22 seconds
Build - Prep                  PASS      0.55 seconds
Build - Configure             PASS      8.74 seconds
Build - Make                  PASS      1280.85 seconds
Make Check                    PASS      11.53 seconds
Make Check w/Valgrind         PASS      433.72 seconds
Make Distcheck                PASS      225.36 seconds
Build w/ext ELL - Configure   PASS      8.31 seconds
Build w/ext ELL - Make        PASS      1228.49 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth
Szymon Janc June 27, 2022, 8:25 a.m. UTC | #2
Hi,

On Fri, 24 Jun 2022 at 11:29, <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=653494
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      1.09 seconds
> GitLint                       PASS      0.73 seconds
> Prep - Setup ELL              PASS      43.22 seconds
> Build - Prep                  PASS      0.55 seconds
> Build - Configure             PASS      8.74 seconds
> Build - Make                  PASS      1280.85 seconds
> Make Check                    PASS      11.53 seconds
> Make Check w/Valgrind         PASS      433.72 seconds
> Make Distcheck                PASS      225.36 seconds
> Build w/ext ELL - Configure   PASS      8.31 seconds
> Build w/ext ELL - Make        PASS      1228.49 seconds
> Incremental Build with patchesPASS      0.00 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth
>

Applied.
patchwork-bot+bluetooth@kernel.org June 27, 2022, 8:30 a.m. UTC | #3
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Szymon Janc <szymon.janc@codecoup.pl>:

On Fri, 24 Jun 2022 10:25:41 +0200 you wrote:
> This fix regression introduced by "monitor: Fix memory leaks".
> J-Link shared library is in use if jlink_init() returns 0 and thus
> handle shall not be closed.
> ---
>  monitor/jlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - monitor: Fix crash when using RTT backend
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1d6cfb8e625a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/monitor/jlink.c b/monitor/jlink.c
index f1d8ce660..f9d4037f4 100644
--- a/monitor/jlink.c
+++ b/monitor/jlink.c
@@ -112,7 +112,7 @@  int jlink_init(void)
 		return -EIO;
 	}
 
-	dlclose(so);
+	/* don't dlclose(so) here cause symbols from it are in use now */
 	return 0;
 }