| Message ID | f3b97c7c-1094-4e46-20d8-4321716d6f3f@I-love.SAKURA.ne.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: mpt3sas: Remove flush_scheduled_work() call. | expand |
On Thu, 9 Jun 2022 22:26:48 +0900, Tetsuo Handa wrote: > It seems to me that mpt3sas driver is using dedicated workqueues and > is not calling schedule{,_delayed}_work{,_on}(). Then, there will be > no work to flush using flush_scheduled_work(). > > Applied to 5.20/scsi-queue, thanks! [1/1] scsi: mpt3sas: Remove flush_scheduled_work() call. https://git.kernel.org/mkp/scsi/c/90c3ca3f247d
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index b519f4b59d30..9ee27add839a 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -12409,7 +12409,6 @@ scsih_suspend(struct device *dev) return rc; mpt3sas_base_stop_watchdog(ioc); - flush_scheduled_work(); scsi_block_requests(shost); _scsih_nvme_shutdown(ioc); ioc_info(ioc, "pdev=0x%p, slot=%s, entering operating state\n",
It seems to me that mpt3sas driver is using dedicated workqueues and is not calling schedule{,_delayed}_work{,_on}(). Then, there will be no work to flush using flush_scheduled_work(). Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> --- Please see commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") for background. drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 - 1 file changed, 1 deletion(-)