| Message ID | 20220627131543.410971-7-michal.orzel@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/arm: use unsigned int instead of plain unsigned | expand |
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel <michal.orzel@arm.com> Acked-by: Jan Beulich <jbeulich@suse.com>
On 6/27/22 09:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel <michal.orzel@arm.com> > --- > xen/xsm/flask/ss/avtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c > index 017f5183de..9761d028d8 100644 > --- a/xen/xsm/flask/ss/avtab.c > +++ b/xen/xsm/flask/ss/avtab.c > @@ -349,7 +349,7 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol, > struct avtab_key key; > struct avtab_datum datum; > int i, rc; > - unsigned set; > + unsigned int set; > > memset(&key, 0, sizeof(struct avtab_key)); > memset(&datum, 0, sizeof(struct avtab_datum)); Is this not v2? Jason gave a Rb on the similar patch if I am not mistaken. v/r, dps
Hi Daniel, On 27.06.2022 21:19, Daniel P. Smith wrote: > > On 6/27/22 09:15, Michal Orzel wrote: >> This is just for the style and consistency reasons as the former is >> being used more often than the latter. >> >> Signed-off-by: Michal Orzel <michal.orzel@arm.com> >> --- >> xen/xsm/flask/ss/avtab.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c >> index 017f5183de..9761d028d8 100644 >> --- a/xen/xsm/flask/ss/avtab.c >> +++ b/xen/xsm/flask/ss/avtab.c >> @@ -349,7 +349,7 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol, >> struct avtab_key key; >> struct avtab_datum datum; >> int i, rc; >> - unsigned set; >> + unsigned int set; >> >> memset(&key, 0, sizeof(struct avtab_key)); >> memset(&datum, 0, sizeof(struct avtab_datum)); > > Is this not v2? Jason gave a Rb on the similar patch if I am not mistaken. > No it is not. This applies to all the patches in this series that was pushed as a new one due to different justification/commit titles/commit msgs (see cover letter). > v/r, > dps Cheers, Michal
diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c index 017f5183de..9761d028d8 100644 --- a/xen/xsm/flask/ss/avtab.c +++ b/xen/xsm/flask/ss/avtab.c @@ -349,7 +349,7 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol, struct avtab_key key; struct avtab_datum datum; int i, rc; - unsigned set; + unsigned int set; memset(&key, 0, sizeof(struct avtab_key)); memset(&datum, 0, sizeof(struct avtab_datum));
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel <michal.orzel@arm.com> --- xen/xsm/flask/ss/avtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)