| Message ID | 20220627135938.2901871-1-stephan.gerhold@kernkonzept.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: msm8992-*: Fix vdd_lvs1_2-supply typo | expand |
On 27.06.2022 15:59, Stephan Gerhold wrote: > "make dtbs_check" complains about the missing "-supply" suffix for > vdd_lvs1_2 which is clearly a typo, originally introduced in the > msm8994-smd-rpm.dtsi file and apparently later copied to > msm8992-xiaomi-libra.dts: > > msm8992-lg-bullhead-rev-10/101.dtb: pm8994-regulators: 'vdd_lvs1_2' > does not match any of the regexes: > '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' > From schema: regulator/qcom,smd-rpm-regulator.yaml > > msm8992-xiaomi-libra.dtb: pm8994-regulators: 'vdd_lvs1_2' > does not match any of the regexes: > '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' > From schema: regulator/qcom,smd-rpm-regulator.yaml > > Reported-by: Rob Herring <robh@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Fixes: f3b2c99e73be ("arm64: dts: Enable onboard SDHCI on msm8992") > Fixes: 0f5cdb31e850 ("arm64: dts: qcom: Add Xiaomi Libra (Mi 4C) device tree") > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > This fixes the dtbs_check failure reported by Rob in my unrelated patch: > https://lore.kernel.org/linux-arm-msm/1656091594.427255.146351.nullmailer@robh.at.kernel.org/ > --- > arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 2 +- > arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > index 3b0cc85d6674..71e373b11de9 100644 > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > @@ -74,7 +74,7 @@ pm8994_regulators: pm8994-regulators { > vdd_l17_29-supply = <&vph_pwr>; > vdd_l20_21-supply = <&vph_pwr>; > vdd_l25-supply = <&pm8994_s5>; > - vdd_lvs1_2 = <&pm8994_s4>; > + vdd_lvs1_2-supply = <&pm8994_s4>; > > /* S1, S2, S6 and S12 are managed by RPMPD */ > > diff --git a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts > index 7748b745a5df..afa91ca9a3dc 100644 > --- a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts > +++ b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts > @@ -171,7 +171,7 @@ pm8994-regulators { > vdd_l17_29-supply = <&vph_pwr>; > vdd_l20_21-supply = <&vph_pwr>; > vdd_l25-supply = <&pm8994_s5>; > - vdd_lvs1_2 = <&pm8994_s4>; > + vdd_lvs1_2-supply = <&pm8994_s4>; > > /* S1, S2, S6 and S12 are managed by RPMPD */ >
On Mon, 27 Jun 2022 15:59:38 +0200, Stephan Gerhold wrote: > "make dtbs_check" complains about the missing "-supply" suffix for > vdd_lvs1_2 which is clearly a typo, originally introduced in the > msm8994-smd-rpm.dtsi file and apparently later copied to > msm8992-xiaomi-libra.dts: > > msm8992-lg-bullhead-rev-10/101.dtb: pm8994-regulators: 'vdd_lvs1_2' > does not match any of the regexes: > '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' > From schema: regulator/qcom,smd-rpm-regulator.yaml > > [...] Applied, thanks! [1/1] arm64: dts: qcom: msm8992-*: Fix vdd_lvs1_2-supply typo commit: 5fb779558f1c97e2bf2794cb59553e569c38e2f9 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi index 3b0cc85d6674..71e373b11de9 100644 --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi @@ -74,7 +74,7 @@ pm8994_regulators: pm8994-regulators { vdd_l17_29-supply = <&vph_pwr>; vdd_l20_21-supply = <&vph_pwr>; vdd_l25-supply = <&pm8994_s5>; - vdd_lvs1_2 = <&pm8994_s4>; + vdd_lvs1_2-supply = <&pm8994_s4>; /* S1, S2, S6 and S12 are managed by RPMPD */ diff --git a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts index 7748b745a5df..afa91ca9a3dc 100644 --- a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts +++ b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts @@ -171,7 +171,7 @@ pm8994-regulators { vdd_l17_29-supply = <&vph_pwr>; vdd_l20_21-supply = <&vph_pwr>; vdd_l25-supply = <&pm8994_s5>; - vdd_lvs1_2 = <&pm8994_s4>; + vdd_lvs1_2-supply = <&pm8994_s4>; /* S1, S2, S6 and S12 are managed by RPMPD */
"make dtbs_check" complains about the missing "-supply" suffix for vdd_lvs1_2 which is clearly a typo, originally introduced in the msm8994-smd-rpm.dtsi file and apparently later copied to msm8992-xiaomi-libra.dts: msm8992-lg-bullhead-rev-10/101.dtb: pm8994-regulators: 'vdd_lvs1_2' does not match any of the regexes: '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' From schema: regulator/qcom,smd-rpm-regulator.yaml msm8992-xiaomi-libra.dtb: pm8994-regulators: 'vdd_lvs1_2' does not match any of the regexes: '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' From schema: regulator/qcom,smd-rpm-regulator.yaml Reported-by: Rob Herring <robh@kernel.org> Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Fixes: f3b2c99e73be ("arm64: dts: Enable onboard SDHCI on msm8992") Fixes: 0f5cdb31e850 ("arm64: dts: qcom: Add Xiaomi Libra (Mi 4C) device tree") Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> --- This fixes the dtbs_check failure reported by Rob in my unrelated patch: https://lore.kernel.org/linux-arm-msm/1656091594.427255.146351.nullmailer@robh.at.kernel.org/ --- arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)