| Message ID | 20220623084347.38207-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: gadget: Fix unsigned comparison with less than zero | expand |
On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> What commit does this fix? thanks, greg k-h
Sorry, we didn't see this patch. commit c09b1f372e746aeeb61ef8ffe0fea3970fd9273e ------------------------------------------------------------------ 发件人：Greg KH <gregkh@linuxfoundation.org> 发送时间：2022年6月24日(星期五) 19:45 收件人：Jiapeng Chong <jiapeng.chong@linux.alibaba.com> 抄 送：neal_liu <neal_liu@aspeedtech.com>; balbi <balbi@kernel.org>; joel <joel@jms.id.au>; andrew <andrew@aj.id.au>; sumit.semwal <sumit.semwal@linaro.org>; christian.koenig <christian.koenig@amd.com>; linux-aspeed <linux-aspeed@lists.ozlabs.org>; linux-usb <linux-usb@vger.kernel.org>; linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org>; linux-media <linux-media@vger.kernel.org>; dri-devel <dri-devel@lists.freedesktop.org>; linaro-mm-sig <linaro-mm-sig@lists.linaro.org> 主 题：Re: [PATCH] usb: gadget: Fix unsigned comparison with less than zero On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> What commit does this fix? thanks, greg k-h
On Wed, Jun 29, 2022 at 01:51:01PM +0800, Jiapeng.Chong wrote: > Sorry, we didn't see this patch. > commit c09b1f372e746aeeb61ef8ffe0fea3970fd9273e I am sorry, I do not understand what you mean here at all. confused, greg k-h
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index 1fc15228ff15..387a7abdcee4 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -476,8 +476,8 @@ static int ast_dma_descriptor_setup(struct ast_udc_ep *ep, u32 dma_buf, { struct ast_udc_dev *udc = ep->udc; struct device *dev = &udc->pdev->dev; - u32 offset, chunk; - int count, last; + u32 offset; + int count, last, chunk; if (!ep->descs) { dev_warn(dev, "%s: Empty DMA descs list failure\n",
This was found by coccicheck: ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/usb/gadget/udc/aspeed_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)