| Message ID | 20220627131415.2868938-2-stephan.gerhold@kernkonzept.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: qcom: tsens: Add data for MSM8909 | expand |
On 27/06/2022 15:14, Stephan Gerhold wrote: > Since the SoC compatibles must be followed by the IP version compatible > (e.g. compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1";) it is > redundant to list all the SoC compatibles again in the if statement. > It will already match the IP-version compatible. > > The list has already become inconsistent since for example > "qcom,msm8939-tsens" is covered by the if statement but is not listed > there explicitly like the other SoCs. > > Simplify this by dropping the redundant SoC compatibles. ipq8064 and > msm8960 are still needed because they do not have an IP-version > compatible. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 038d81338fcf..e93e9deec6f6 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -117,12 +117,7 @@ allOf: contains: enum: - qcom,ipq8064-tsens - - qcom,mdm9607-tsens - - qcom,msm8916-tsens - qcom,msm8960-tsens - - qcom,msm8974-tsens - - qcom,msm8976-tsens - - qcom,qcs404-tsens - qcom,tsens-v0_1 - qcom,tsens-v1 then:
Since the SoC compatibles must be followed by the IP version compatible (e.g. compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1";) it is redundant to list all the SoC compatibles again in the if statement. It will already match the IP-version compatible. The list has already become inconsistent since for example "qcom,msm8939-tsens" is covered by the if statement but is not listed there explicitly like the other SoCs. Simplify this by dropping the redundant SoC compatibles. ipq8064 and msm8960 are still needed because they do not have an IP-version compatible. Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 5 ----- 1 file changed, 5 deletions(-)