| Message ID | 20220629112913.1210933-14-alexander.usyskin@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | GSC support for XeHP SDV and DG2 platforms | expand |
On Wed, Jun 29, 2022 at 02:29:12PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler <tomas.winkler@intel.com> > > Add pxp mode devstate to debugfs to monitor > pxp state machine progress. During debug > it is important to understand in what state > the pxp handshake is. You have 72 columns for changelog text, as your editor will tell you when you run git commit... Anyway, it's better than nothing, but really, do you think this is a good changelog description? That last sentence means nothing. I too think it is important to understand things... {sigh} Anyway, you all are pushing this hard for some crazy reason, and it's only a debugfs file, so it doesn't matter much, but it feels indicative of other patches from your employer for the past few years so I'll be a pain and ask for you to fix it up again. thanks, greg k-h
On Wed, Jun 29, 2022 at 02:29:12PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler <tomas.winkler@intel.com> > > Add pxp mode devstate to debugfs to monitor > pxp state machine progress. During debug > it is important to understand in what state > the pxp handshake is. > > CC: Vitaly Lubart <vitaly.lubart@intel.com> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Also, you forgot to sign off on this, that's grounds for rejection alone...
diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c index 1ce61e9e24fc..4074fec866a6 100644 --- a/drivers/misc/mei/debugfs.c +++ b/drivers/misc/mei/debugfs.c @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused) } DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active); +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state) +{ +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state + switch (state) { + MEI_PXP_MODE(DEFAULT); + MEI_PXP_MODE(INIT); + MEI_PXP_MODE(SETUP); + MEI_PXP_MODE(READY); + default: + return "unknown"; + } +#undef MEI_PXP_MODE +} + static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused) { struct mei_device *dev = m->private; @@ -112,6 +126,9 @@ static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused) seq_printf(m, "pg: %s, %s\n", mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED", mei_pg_state_str(mei_pg_state(dev))); + + seq_printf(m, "pxp: %s\n", mei_dev_pxp_mode_str(dev->pxp_mode)); + return 0; } DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_devstate);