| Message ID | 20220629012702.425574-1-kishen.maloor@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: support MP_PRIO signals with userspace PMs | expand |
On Tue, 28 Jun 2022, Kishen Maloor wrote: > This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs > to issue MP_PRIO signals over a selected (by local and remote address+port) > subflow in a MPTCP connection. It also adds self tests for this > change. > > This patch series has been rebased to the series (in review) titled > "Locking fixes for subflow flag changes". > > v2: > -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. > > v3: > -use local and remote address+port (instead of address ID) alongwith the > connection token to select a subflow. > > v4: > -fixed bug during rebase in v3. Thanks Kishen. v4 looks good to me, and the builds look good (I pushed equivalent commits to github to trigger a build): https://cirrus-ci.com/build/6289402744799232 https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638 Looks like the github action got a little confused by the exact version of the patches not being in patchwork. Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> At the meeting last week Paolo said he was planning to take a look as well. > > Kishen Maloor (2): > mptcp: netlink: issue MP_PRIO signals from userspace PMs > selftests: mptcp: userspace PM support for MP_PRIO signals > > net/mptcp/pm_netlink.c | 30 ++++++-- > net/mptcp/pm_userspace.c | 30 ++++++++ > net/mptcp/protocol.h | 8 +- > tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 73 ++++++++++++++++++- > .../selftests/net/mptcp/userspace_pm.sh | 32 ++++++++ > 5 files changed, 165 insertions(+), 8 deletions(-) > > -- > 2.31.1 > > -- Mat Martineau Intel
On Tue, 2022-06-28 at 20:37 -0700, Mat Martineau wrote: > On Tue, 28 Jun 2022, Kishen Maloor wrote: > > > This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs > > to issue MP_PRIO signals over a selected (by local and remote address+port) > > subflow in a MPTCP connection. It also adds self tests for this > > change. > > > > This patch series has been rebased to the series (in review) titled > > "Locking fixes for subflow flag changes". > > > > v2: > > -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. > > > > v3: > > -use local and remote address+port (instead of address ID) alongwith the > > connection token to select a subflow. > > > > v4: > > -fixed bug during rebase in v3. > > Thanks Kishen. v4 looks good to me, and the builds look good (I pushed > equivalent commits to github to trigger a build): > > https://cirrus-ci.com/build/6289402744799232 > https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638 > > Looks like the github action got a little confused by the exact version of > the patches not being in patchwork. > > > Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> > > At the meeting last week Paolo said he was planning to take a look as > well. LGTM, too. Acked-by: Paolo Abeni <pabeni@redhat.com> Thanks! Paolo
On Wed, 29 Jun 2022, Paolo Abeni wrote: > On Tue, 2022-06-28 at 20:37 -0700, Mat Martineau wrote: >> On Tue, 28 Jun 2022, Kishen Maloor wrote: >> >>> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs >>> to issue MP_PRIO signals over a selected (by local and remote address+port) >>> subflow in a MPTCP connection. It also adds self tests for this >>> change. >>> >>> This patch series has been rebased to the series (in review) titled >>> "Locking fixes for subflow flag changes". >>> >>> v2: >>> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. >>> >>> v3: >>> -use local and remote address+port (instead of address ID) alongwith the >>> connection token to select a subflow. >>> >>> v4: >>> -fixed bug during rebase in v3. >> >> Thanks Kishen. v4 looks good to me, and the builds look good (I pushed >> equivalent commits to github to trigger a build): >> >> https://cirrus-ci.com/build/6289402744799232 >> https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638 >> >> Looks like the github action got a little confused by the exact version of >> the patches not being in patchwork. >> >> >> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> >> >> At the meeting last week Paolo said he was planning to take a look as >> well. > > LGTM, too. > > Acked-by: Paolo Abeni <pabeni@redhat.com> > Thanks for the ack. As Kishen noted above, this series depends on "Locking fixes for subflow flag changes" - have you had a chance to look at that one? Like I mentioned in the other thread, it's almost a match for your locking changes in the RFC MPC MP_PRIO series. -- Mat Martineau Intel
Hi Kishen, Mat, Paolo, On 29/06/2022 03:27, Kishen Maloor wrote: > This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs > to issue MP_PRIO signals over a selected (by local and remote address+port) > subflow in a MPTCP connection. It also adds self tests for this > change. > > This patch series has been rebased to the series (in review) titled > "Locking fixes for subflow flag changes". > > v2: > -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. > > v3: > -use local and remote address+port (instead of address ID) alongwith the > connection token to select a subflow. > > v4: > -fixed bug during rebase in v3. > > Kishen Maloor (2): > mptcp: netlink: issue MP_PRIO signals from userspace PMs > selftests: mptcp: userspace PM support for MP_PRIO signals Thank you for the patches and the reviews! Now in our tree (fixes for -net) with Mat's RvB tags and Paolo's ACK. New patches for t/upstream-net: - 98405967fe79: mptcp: netlink: issue MP_PRIO signals from userspace PMs - 2ddc9af505ee: selftests: mptcp: userspace PM support for MP_PRIO signals - Results: 3c88708b1aca..bf5586d50d31 (export-net) New patches for t/upstream: - 98405967fe79: mptcp: netlink: issue MP_PRIO signals from userspace PMs - 2ddc9af505ee: selftests: mptcp: userspace PM support for MP_PRIO signals - Results: ce6114ac321d..f970a45a66c3 (export) Builds and tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20220630T174520 https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export-net https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220630T174520 https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export Cheers, Matt