| Message ID | 1655200111-18357-5-git-send-email-quic_c_skakit@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand |
On Tue, 14 Jun 2022, Satya Priya wrote: > Add the reset-gpio toggling in the pm8008_probe() to bring > pm8008 chip out of reset instead of doing it in DT node using > "output-high" property. > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > --- > Changes in V15: > - None. > > Changes in V14: > - None. > > Changes in V13: > - None. > > drivers/mfd/qcom-pm8008.c | 6 ++++++ > 1 file changed, 6 insertions(+) Applied, thanks.
On Thu, 16 Jun 2022, Lee Jones wrote: > On Tue, 14 Jun 2022, Satya Priya wrote: > > > Add the reset-gpio toggling in the pm8008_probe() to bring > > pm8008 chip out of reset instead of doing it in DT node using > > "output-high" property. > > > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > --- > > Changes in V15: > > - None. > > > > Changes in V14: > > - None. > > > > Changes in V13: > > - None. > > > > drivers/mfd/qcom-pm8008.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Applied, thanks. Sorry, wrong key-combo: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
On Jun 14 2022 15:18, Satya Priya wrote: > Add the reset-gpio toggling in the pm8008_probe() to bring > pm8008 chip out of reset instead of doing it in DT node using > "output-high" property. > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Acked-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index c472d7f..5a670b0 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -4,6 +4,7 @@ */ #include <linux/bitops.h> +#include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/irq.h> @@ -221,6 +222,7 @@ static int pm8008_probe(struct i2c_client *client) { int rc; struct pm8008_data *chip; + struct gpio_desc *reset_gpio; chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); if (!chip) @@ -233,6 +235,10 @@ static int pm8008_probe(struct i2c_client *client) i2c_set_clientdata(client, chip); + reset_gpio = devm_gpiod_get(chip->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(reset_gpio)) + return PTR_ERR(reset_gpio); + if (of_property_read_bool(chip->dev->of_node, "interrupt-controller")) { rc = pm8008_probe_irq_peripherals(chip, client->irq); if (rc)