| Message ID | 165603872171.551046.913207574344536475.stgit@dwillia2-xfh |
|---|---|
| State | Superseded |
| Headers | show |
| Series | CXL PMEM Region Provisioning | expand |
On Thu, Jun 23, 2022 at 07:45:21PM -0700, Dan Williams wrote: > From: Ben Widawsky <bwidawsk@kernel.org> > > Save a few characters and use the already initialized local variable. > > Signed-off-by: Ben Widawsky <bwidawsk@kernel.org> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> > --- > drivers/cxl/core/hdm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > index bfc8ee876278..ba3d2d959c71 100644 > --- a/drivers/cxl/core/hdm.c > +++ b/drivers/cxl/core/hdm.c > @@ -251,8 +251,7 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm) > return PTR_ERR(cxld); > } > > - rc = init_hdm_decoder(port, cxld, target_map, > - cxlhdm->regs.hdm_decoder, i); > + rc = init_hdm_decoder(port, cxld, target_map, hdm, i); > if (rc) { > put_device(&cxld->dev); > failed++; >
On Thu, 23 Jun 2022 19:45:21 -0700 Dan Williams <dan.j.williams@intel.com> wrote: > From: Ben Widawsky <bwidawsk@kernel.org> > > Save a few characters and use the already initialized local variable. > > Signed-off-by: Ben Widawsky <bwidawsk@kernel.org> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/hdm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > index bfc8ee876278..ba3d2d959c71 100644 > --- a/drivers/cxl/core/hdm.c > +++ b/drivers/cxl/core/hdm.c > @@ -251,8 +251,7 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm) > return PTR_ERR(cxld); > } > > - rc = init_hdm_decoder(port, cxld, target_map, > - cxlhdm->regs.hdm_decoder, i); > + rc = init_hdm_decoder(port, cxld, target_map, hdm, i); > if (rc) { > put_device(&cxld->dev); > failed++; >
On Thu, Jun 23, 2022 at 07:45:21PM -0700, Dan Williams wrote: > From: Ben Widawsky <bwidawsk@kernel.org> > > Save a few characters and use the already initialized local variable. > > Signed-off-by: Ben Widawsky <bwidawsk@kernel.org> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > drivers/cxl/core/hdm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > index bfc8ee876278..ba3d2d959c71 100644 > --- a/drivers/cxl/core/hdm.c > +++ b/drivers/cxl/core/hdm.c > @@ -251,8 +251,7 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm) > return PTR_ERR(cxld); > } > > - rc = init_hdm_decoder(port, cxld, target_map, > - cxlhdm->regs.hdm_decoder, i); > + rc = init_hdm_decoder(port, cxld, target_map, hdm, i); > if (rc) { > put_device(&cxld->dev); > failed++; > > Looks good. Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c index bfc8ee876278..ba3d2d959c71 100644 --- a/drivers/cxl/core/hdm.c +++ b/drivers/cxl/core/hdm.c @@ -251,8 +251,7 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm) return PTR_ERR(cxld); } - rc = init_hdm_decoder(port, cxld, target_map, - cxlhdm->regs.hdm_decoder, i); + rc = init_hdm_decoder(port, cxld, target_map, hdm, i); if (rc) { put_device(&cxld->dev); failed++;