mbox series

[v3,0/2] blk-cgroup: duplicated code refactor

Message ID 20220629070917.3113016-1-yanaijie@huawei.com (mailing list archive)
Headers show
Series blk-cgroup: duplicated code refactor | expand

Message

Jason Yan June 29, 2022, 7:09 a.m. UTC
Two duplicated code segment refactors. No functional change.

v2->v3: Fix indentation and add review tags.
v1->v2: Remove inline keyword of blkcg_iostat_update().

Jason Yan (2):
  blk-cgroup: factor out blkcg_iostat_update()
  blk-cgroup: factor out blkcg_free_all_cpd()

 block/blk-cgroup.c | 73 ++++++++++++++++++++++++----------------------
 1 file changed, 38 insertions(+), 35 deletions(-)

Comments

Jens Axboe June 29, 2022, 5:09 p.m. UTC | #1
On 6/29/22 1:09 AM, Jason Yan wrote:
> Two duplicated code segment refactors. No functional change.
> 
> v2->v3: Fix indentation and add review tags.
> v1->v2: Remove inline keyword of blkcg_iostat_update().
> 
> Jason Yan (2):
>   blk-cgroup: factor out blkcg_iostat_update()
>   blk-cgroup: factor out blkcg_free_all_cpd()
> 
>  block/blk-cgroup.c | 73 ++++++++++++++++++++++++----------------------
>  1 file changed, 38 insertions(+), 35 deletions(-)

Like I told Yu, stop using the huawei email until your MTA
misconfiguration issues are fixed. They end up in spam and risk getting
lost. This series was one of them.
Jens Axboe June 29, 2022, 5:10 p.m. UTC | #2
On Wed, 29 Jun 2022 15:09:15 +0800, Jason Yan wrote:
> Two duplicated code segment refactors. No functional change.
> 
> v2->v3: Fix indentation and add review tags.
> v1->v2: Remove inline keyword of blkcg_iostat_update().
> 
> Jason Yan (2):
>   blk-cgroup: factor out blkcg_iostat_update()
>   blk-cgroup: factor out blkcg_free_all_cpd()
> 
> [...]

Applied, thanks!

[1/2] blk-cgroup: factor out blkcg_iostat_update()
      commit: 362b8c16f8fc73fddfe4bded25055fa0c9e2bf1e
[2/2] blk-cgroup: factor out blkcg_free_all_cpd()
      commit: e55cf798140518b900e5254093f1195f65c23026

Best regards,
Yu Kuai June 30, 2022, 1:46 a.m. UTC | #3
在 2022/06/30 1:09, Jens Axboe 写道:
> On 6/29/22 1:09 AM, Jason Yan wrote:
>> Two duplicated code segment refactors. No functional change.
>>
>> v2->v3: Fix indentation and add review tags.
>> v1->v2: Remove inline keyword of blkcg_iostat_update().
>>
>> Jason Yan (2):
>>    blk-cgroup: factor out blkcg_iostat_update()
>>    blk-cgroup: factor out blkcg_free_all_cpd()
>>
>>   block/blk-cgroup.c | 73 ++++++++++++++++++++++++----------------------
>>   1 file changed, 38 insertions(+), 35 deletions(-)
> 
> Like I told Yu, stop using the huawei email until your MTA
> misconfiguration issues are fixed. They end up in spam and risk getting
> lost. This series was one of them.
> 

Hi,

I'll try to push our IT to solve the issues, and in the meantime i'll
let my colleagues know about this. However, I'm afraid this can't be
avoid completely.

Thanks,
Kuai
John Garry June 30, 2022, 8:16 a.m. UTC | #4
On 29/06/2022 18:09, Jens Axboe wrote:
> Like I told Yu, stop using the huawei email until your MTA
> misconfiguration issues are fixed. They end up in spam and risk getting
> lost. This series was one of them.

Hi Jens,

Just wondering - are there any of my mails in your spam folder?

thanks,
John
Jens Axboe June 30, 2022, 1:10 p.m. UTC | #5
On 6/30/22 2:16 AM, John Garry wrote:
> On 29/06/2022 18:09, Jens Axboe wrote:
>> Like I told Yu, stop using the huawei email until your MTA
>> misconfiguration issues are fixed. They end up in spam and risk getting
>> lost. This series was one of them.
> 
> Hi Jens,
> 
> Just wondering - are there any of my mails in your spam folder?

Don't recall seeing any of yours in spam.
Bart Van Assche June 30, 2022, 6:03 p.m. UTC | #6
On 6/30/22 01:16, John Garry wrote:
> Just wondering - are there any of my mails in your spam folder?

This morning I found the following email from you in my spam folder:

https://lore.kernel.org/linux-scsi/82e30007-1ffc-92e4-38b5-eaf7dd2e316d@huawei.com/

I'm going to reinstall my email filter that keeps Huawei emails out of 
the spam folder.

If the following information has not yet been shared with your IT 
department, please share it: https://support.google.com/a/answer/174124

Bart.
Jason Yan July 1, 2022, 1:51 a.m. UTC | #7
On 2022/7/1 2:03, Bart Van Assche wrote:
> On 6/30/22 01:16, John Garry wrote:
>> Just wondering - are there any of my mails in your spam folder?
> 
> This morning I found the following email from you in my spam folder:
> 
> https://lore.kernel.org/linux-scsi/82e30007-1ffc-92e4-38b5-eaf7dd2e316d@huawei.com/ 
> 
> 
> I'm going to reinstall my email filter that keeps Huawei emails out of 
> the spam folder.
> 
> If the following information has not yet been shared with your IT 
> department, please share it: https://support.google.com/a/answer/174124
> 
> Bart.
> .

Sorry to bring your guys so many troubles.

And thanks Bart. Yes our IT department is planning to support DKIM. But
this needs time and they have to consider the performance issues. And we
are going to try a workaround approach before they fix it entirely.

Thanks you so much again.

Jason.