| Message ID | 20220528160353.157870-1-konrad.dybcio@somainline.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/4] drm/msm/adreno: Remove dead code | expand |
On 5/28/2022 9:33 PM, Konrad Dybcio wrote: > This BUG_ON will never be reached, and there is a comment 20 above > explaining why. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 3e325e2a2b1b..b1c876c339d0 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -1548,8 +1548,6 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node) > if (ret) > goto err_memory; > } else { > - BUG_ON(adreno_is_a660_family(adreno_gpu)); > - > /* HFI v1, has sptprac */ > gmu->legacy = true; > Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com> -Akhil
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index 3e325e2a2b1b..b1c876c339d0 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1548,8 +1548,6 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node) if (ret) goto err_memory; } else { - BUG_ON(adreno_is_a660_family(adreno_gpu)); - /* HFI v1, has sptprac */ gmu->legacy = true;
This BUG_ON will never be reached, and there is a comment 20 above explaining why. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 -- 1 file changed, 2 deletions(-)