| Message ID | YqcptnhfCtUn2+T6@Sun (mailing list archive) |
|---|---|
| Headers | show |
| Series | CanoKey: Fix xHCI compatibility and CCID ZLP | expand |
On Mon, Jun 13, 2022 at 08:12:38PM +0800, Hongren (Zenithal) Zheng wrote: > --- > v2: > * use usb_ep_get instead of recording ep_in_pointer > as suggested by kraxel > * CI result for v2 is at > https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905 Hi kraxel, is there any further feedback on this? BTW, as the commit "add myself as CanoKey maintainer" has been merged, how should I submit patches on CanoKey to you and QEMU? For my own patches, I assume I should submit them as PATCHes to you and the list, and after enough review it will be passed via you by a git PULL. For other contributors, before I can send PULL (my key is not signed yet) I think I should first give Reviewed-by tags then request you to pass them. After I can send PULL, I think I can just send it to you (or who will be more appropriate?) Regards, > > Hongren (Zenithal) Zheng (3): > hw/usb/canokey: Fix CCID ZLP > hw/usb/canokey: fix compatibility of qemu-xhci > docs/system/devices/usb/canokey: remove limitations on qemu-xhci > > docs/system/devices/canokey.rst | 10 ---------- > hw/usb/canokey.c | 30 ++++++++++++++++++++++++++---- > 2 files changed, 26 insertions(+), 14 deletions(-) > > -- > 2.35.1 >
On Thu, Jun 23, 2022 at 11:16:39PM +0800, Hongren (Zenithal) Zheng wrote: > BTW, as the commit "add myself as CanoKey maintainer" has been > merged, how should I submit patches on CanoKey to you and QEMU? Also I want to add CanoKey in ChangeLog/7.1 in QEMU wiki. But the account for wiki should be created by some other people with existing accounts. I wonder if you or anyone on the list could kindly do me a favor? Thanks! My preferred username is Zenithal.
On Thu, Jun 23, 2022 at 11:16:39PM +0800, Hongren (Zenithal) Zheng wrote: > On Mon, Jun 13, 2022 at 08:12:38PM +0800, Hongren (Zenithal) Zheng wrote: > > > --- > > v2: > > * use usb_ep_get instead of recording ep_in_pointer > > as suggested by kraxel > > * CI result for v2 is at > > https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905 > > Hi kraxel, is there any further feedback on this? > > BTW, as the commit "add myself as CanoKey maintainer" has been > merged, how should I submit patches on CanoKey to you and QEMU? Sending to the list with /me Cc'ed is fine. > For other contributors, before I can send PULL (my key is not signed yet) > I think I should first give Reviewed-by tags then request you > to pass them. Yes. Series queued up now. thanks, Gerd
On Fri, Jul 01, 2022 at 12:51:06PM +0200, Gerd Hoffmann wrote: > On Thu, Jun 23, 2022 at 11:16:39PM +0800, Hongren (Zenithal) Zheng wrote: > > On Mon, Jun 13, 2022 at 08:12:38PM +0800, Hongren (Zenithal) Zheng wrote: > > > > > --- > > > v2: > > > * use usb_ep_get instead of recording ep_in_pointer > > > as suggested by kraxel > > > * CI result for v2 is at > > > https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905 > > > > Hi kraxel, is there any further feedback on this? > > > > BTW, as the commit "add myself as CanoKey maintainer" has been > > merged, how should I submit patches on CanoKey to you and QEMU? > > Sending to the list with /me Cc'ed is fine. > > > For other contributors, before I can send PULL (my key is not signed yet) > > I think I should first give Reviewed-by tags then request you > > to pass them. > > Yes. > > Series queued up now. Thanks! > Also I want to add CanoKey in ChangeLog/7.1 in QEMU wiki. > But the account for wiki should be created by some other > people with existing accounts. I wonder if you or anyone > on the list could kindly do me a favor? Thanks! > > My preferred username is Zenithal. Could you please also add a wiki account for me? There are two additional patches reviewed by me, and you have been Cc'ed. I wonder if you could queue them up. [PATCH v4 1/2] hw: canokey: Remove HS support as not compliant to the spec [PATCH v4] docs/system/devices/canokey: Document limitations on usb-ehci > > thanks, > Gerd >
In patch v5 [1] of Introduce CanoKey QEMU I said that canokey-qemu was incompatible with qemu-xhci. kraxel kindly suggested[2] that it should be the problem of usb_wakeup So I fixed it in this patch set. Now that the v5 patch has been in the process of git PULL [3], I think it would be better to post a new patch set instead of sending out v6, which would make maintainer's tree back and forth. This patch should be applied after [1]. As for the CCID ZLP issue, it is described in the comment and commit message. I added a commit in https://github.com/canokeys/canokey-qemu to export the EP num in the header, so hw/usb/canokey.c in qemu could use it for CTAPHID quirks. If you want to compile this version when --enable-canokey, make sure to use the latest libcanokey-qemu.so The CI result for this PATCH is at [4]. The failure for amd64-debian-container seems irrelevent to this patchset. [1] https://lore.kernel.org/qemu-devel/YoY5k0PQny8WtAHi@Sun/ [2] https://lore.kernel.org/qemu-devel/20220609095659.ulgk64bx3nlqzs2k@sirius.home.kraxel.org/ [3] https://lore.kernel.org/qemu-devel/20220610092043.1874654-1-kraxel@redhat.com/ [4] https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/561801062 --- v2: * use usb_ep_get instead of recording ep_in_pointer as suggested by kraxel * CI result for v2 is at https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905 Hongren (Zenithal) Zheng (3): hw/usb/canokey: Fix CCID ZLP hw/usb/canokey: fix compatibility of qemu-xhci docs/system/devices/usb/canokey: remove limitations on qemu-xhci docs/system/devices/canokey.rst | 10 ---------- hw/usb/canokey.c | 30 ++++++++++++++++++++++++++---- 2 files changed, 26 insertions(+), 14 deletions(-)