| Message ID | 20220701090547.21429-2-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Complete driver nodes for MT8192 SoC | expand |
On Fri, Jul 1, 2022 at 5:05 PM Allen-KH Cheng <allen-kh.cheng@mediatek.com> wrote: > > The compatible “mediatek,mt8192-disp-rdma” is being used for reading > the data into DMA for back-end panel driver in mt8192 but there is > no difference between mt8183 and mt8192 in rdma driver. > > Remove compatible “mediatek,mt8192-disp-rdma” from the driver and > should use “mediatek,mt8183-disp-rdma” as fallback in 8192 DTS > according to the mediatek,rdma.yaml. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Hi, Allen: Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. Chen-Yu Tsai <wenst@chromium.org> 於 2022年7月1日 週五 下午6:37寫道： > > On Fri, Jul 1, 2022 at 5:05 PM Allen-KH Cheng > <allen-kh.cheng@mediatek.com> wrote: > > > > The compatible “mediatek,mt8192-disp-rdma” is being used for reading > > the data into DMA for back-end panel driver in mt8192 but there is > > no difference between mt8183 and mt8192 in rdma driver. > > > > Remove compatible “mediatek,mt8192-disp-rdma” from the driver and > > should use “mediatek,mt8183-disp-rdma” as fallback in 8192 DTS > > according to the mediatek,rdma.yaml. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c index 1be4caf9ff96..91add033e7b3 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c @@ -368,10 +368,6 @@ static const struct mtk_disp_rdma_data mt8183_rdma_driver_data = { .fifo_size = 5 * SZ_1K, }; -static const struct mtk_disp_rdma_data mt8192_rdma_driver_data = { - .fifo_size = 5 * SZ_1K, -}; - static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = { { .compatible = "mediatek,mt2701-disp-rdma", .data = &mt2701_rdma_driver_data}, @@ -379,8 +375,6 @@ static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = { .data = &mt8173_rdma_driver_data}, { .compatible = "mediatek,mt8183-disp-rdma", .data = &mt8183_rdma_driver_data}, - { .compatible = "mediatek,mt8192-disp-rdma", - .data = &mt8192_rdma_driver_data}, {}, }; MODULE_DEVICE_TABLE(of, mtk_disp_rdma_driver_dt_match); diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 6abe6bcacbdc..06bd4483744b 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -522,8 +522,6 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { .data = (void *)MTK_DISP_RDMA }, { .compatible = "mediatek,mt8183-disp-rdma", .data = (void *)MTK_DISP_RDMA }, - { .compatible = "mediatek,mt8192-disp-rdma", - .data = (void *)MTK_DISP_RDMA }, { .compatible = "mediatek,mt8173-disp-ufoe", .data = (void *)MTK_DISP_UFOE }, { .compatible = "mediatek,mt8173-disp-wdma",
The compatible “mediatek,mt8192-disp-rdma” is being used for reading the data into DMA for back-end panel driver in mt8192 but there is no difference between mt8183 and mt8192 in rdma driver. Remove compatible “mediatek,mt8192-disp-rdma” from the driver and should use “mediatek,mt8183-disp-rdma” as fallback in 8192 DTS according to the mediatek,rdma.yaml. Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ------ drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 8 deletions(-)