| Message ID | 20220628112939.160737-1-windhl@126.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm: mach-omap2: omap4-common: Fix refcount leak bug | expand |
* Liang He <windhl@126.com> [220628 14:24]: > In omap4_sram_init(), of_find_compatible_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > it is not used anymore. Thanks applying into omap-for-v5.20/soc. Tony
diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 6d1eb4eefefe..d9ed2a5dcd5e 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -140,6 +140,7 @@ static int __init omap4_sram_init(void) __func__); else sram_sync = (void __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE); + of_node_put(np); return 0; }
In omap4_sram_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He <windhl@126.com> --- changelog: v3: change the order of of_node_put() based on tony's advice v2: merge similar bugs in omap2 into one commit v1: fix missing of_node_put() bugs arch/arm/mach-omap2/omap4-common.c | 1 + 1 file changed, 1 insertion(+)