| Message ID | 20220705094239.17174-12-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom,qmp: fix dt-bindings and deprecate lane suffix | expand |
On 05/07/2022 11:42, Johan Hovold wrote: > Drop the unnecessary "lane" suffix from the PHY reset names and mark the > old names as deprecated. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > index 7931b1fd1476..0bea8270b37e 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > @@ -94,11 +94,15 @@ patternProperties: > - description: PHY (lane) reset > > reset-names: > - items: > - - enum: > - - lane0 > - - lane1 > - - lane2 > + oneOf: > + - items: > + - const: lane > + - items: > + - enum: > + - lane0 > + - lane1 > + - lane2 > + deprecated: true > How about just dropping reset-names entirely? Marking entire field deprecated and removing from DTS? The same in the previous patch. Usually one-item xxx-names do not bring any useful information. Best regards, Krzysztof
On Tue, Jul 05, 2022 at 12:12:25PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 11:42, Johan Hovold wrote: > > Drop the unnecessary "lane" suffix from the PHY reset names and mark the > > old names as deprecated. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- > > 1 file changed, 12 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > > index 7931b1fd1476..0bea8270b37e 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > > @@ -94,11 +94,15 @@ patternProperties: > > - description: PHY (lane) reset > > > > reset-names: > > - items: > > - - enum: > > - - lane0 > > - - lane1 > > - - lane2 > > + oneOf: > > + - items: > > + - const: lane > > + - items: > > + - enum: > > + - lane0 > > + - lane1 > > + - lane2 > > + deprecated: true > > > > How about just dropping reset-names entirely? Marking entire field > deprecated and removing from DTS? The same in the previous patch. > > Usually one-item xxx-names do not bring any useful information. Yeah, I agree, that's better. Johan
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 7931b1fd1476..0bea8270b37e 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -94,11 +94,15 @@ patternProperties: - description: PHY (lane) reset reset-names: - items: - - enum: - - lane0 - - lane1 - - lane2 + oneOf: + - items: + - const: lane + - items: + - enum: + - lane0 + - lane1 + - lane2 + deprecated: true "#clock-cells": const: 0 @@ -166,7 +170,7 @@ examples: clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_0_PHY_BCR>; - reset-names = "lane0"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_0_pipe_clk_src"; @@ -182,7 +186,7 @@ examples: clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_1_PHY_BCR>; - reset-names = "lane1"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk_src"; @@ -198,7 +202,7 @@ examples: clocks = <&gcc GCC_PCIE_2_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_2_PHY_BCR>; - reset-names = "lane2"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_2_pipe_clk_src";
Drop the unnecessary "lane" suffix from the PHY reset names and mark the old names as deprecated. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)