| Message ID | 20220704100028.19932-5-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add driver nodes for MT8195 SoC | expand |
Il 04/07/22 12:00, Tinghan Shen ha scritto: > Disable external output reset signal in first round of watchdog reset > to reserve wdt reset reason for debugging watchdog issue. If my understanding of the commit decription is right, then we can clarify that with something like: "[...] for debugging eventual watchdog issues". Otherwise, if this implies that disable-extrst is needed to avoid losing the reset reason stored in the WDT, you could say something like: "Disable external output reset signal in the first round of watchdog reset to avoid losing the reset reason stored in the watchdog registers" After which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Signed-off-by: Fengquan Chen <fengquan.chen@mediatek.com> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 066c14989708..436687ba826f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -327,6 +327,7 @@ > watchdog: watchdog@10007000 { > compatible = "mediatek,mt8195-wdt", > "mediatek,mt6589-wdt"; > + mediatek,disable-extrst; > reg = <0 0x10007000 0 0x100>; > }; >
On Mon, 2022-07-04 at 12:30 +0200, AngeloGioacchino Del Regno wrote: > Il 04/07/22 12:00, Tinghan Shen ha scritto: > > Disable external output reset signal in first round of watchdog reset > > to reserve wdt reset reason for debugging watchdog issue. > > If my understanding of the commit decription is right, then we can clarify > that with something like: "[...] for debugging eventual watchdog issues". > > Otherwise, if this implies that disable-extrst is needed to avoid losing > the reset reason stored in the WDT, you could say something like: > > "Disable external output reset signal in the first round of watchdog reset > to avoid losing the reset reason stored in the watchdog registers" > > After which: > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Ok, I'll update it in next version. Thanks, TingHan
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi index 066c14989708..436687ba826f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi @@ -327,6 +327,7 @@ watchdog: watchdog@10007000 { compatible = "mediatek,mt8195-wdt", "mediatek,mt6589-wdt"; + mediatek,disable-extrst; reg = <0 0x10007000 0 0x100>; };