| Message ID | 20220706042039.5763-2-nandhini.srikandan@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Intel Thunder Bay SPI controller | expand |
On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@intel.com wrote: > From: Nandhini Srikandan <nandhini.srikandan@intel.com> > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions interface") > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com> What is the problem and how does this patch fix it?
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Wednesday, July 6, 2022 5:28 PM > To: Srikandan, Nandhini <nandhini.srikandan@intel.com> > Cc: fancer.lancer@gmail.com; robh+dt@kernel.org; linux- > spi@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; mgross@linux.intel.com; Pan, Kris > <kris.pan@intel.com>; Demakkanavar, Kenchappa > <kenchappa.demakkanavar@intel.com>; Zhou, Furong > <furong.zhou@intel.com>; Sangannavar, Mallikarjunappa > <mallikarjunappa.sangannavar@intel.com>; Vaidya, Mahesh R > <mahesh.r.vaidya@intel.com>; A, Rashmi <rashmi.a@intel.com> > Subject: Re: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro > > On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@intel.com > wrote: > > From: Nandhini Srikandan <nandhini.srikandan@intel.com> > > > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions > interface") > > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com> > > What is the problem and how does this patch fix it? The macro was introduced by Serge Semin in the patch set (2cc8d9227bbb) but it was unused. It is used by one of the patches in the current patchset and without the fix it leads to compilation error. I had included this in v4 and Serge Semin had asked me to add the "Fixes: 2cc8d9227bbb" tag and keep it at the top of the series. So, I have kept it as first patch in this patchset series. - Nandhini
On Wed, Jul 06, 2022 at 02:56:30PM +0000, Srikandan, Nandhini wrote: > > wrote: > > > From: Nandhini Srikandan <nandhini.srikandan@intel.com> > > > > > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions > > interface") > > > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com> > > What is the problem and how does this patch fix it? > The macro was introduced by Serge Semin in the patch set (2cc8d9227bbb) but it was unused. > It is used by one of the patches in the current patchset and without the fix it leads to compilation error. I had included this in v4 and Serge Semin had asked me to add the "Fixes: 2cc8d9227bbb" tag and keep it at the top of the series. So, I have kept it as first patch in this patchset series. This is information that ought to be in the changelog. Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.
Hi Nandhini On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@intel.com wrote: > From: Nandhini Srikandan <nandhini.srikandan@intel.com> > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions interface") > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com> As Mark already noted each patch is supposed to have a changelog [1]. Please add a detailed explanation of the problem above the tags block [1]. [1] "Patch formatting and changelogs" Documentation/process/5.Posting.rst -Sergey > --- > drivers/spi/spi-dw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h > index d5ee5130601e..79d853f6d192 100644 > --- a/drivers/spi/spi-dw.h > +++ b/drivers/spi/spi-dw.h > @@ -23,7 +23,7 @@ > ((_dws)->ip == DW_ ## _ip ## _ID) > > #define __dw_spi_ver_cmp(_dws, _ip, _ver, _op) \ > - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver) > + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver) > > #define dw_spi_ver_is(_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==) > > -- > 2.17.1 >
diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index d5ee5130601e..79d853f6d192 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi/spi-dw.h @@ -23,7 +23,7 @@ ((_dws)->ip == DW_ ## _ip ## _ID) #define __dw_spi_ver_cmp(_dws, _ip, _ver, _op) \ - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver) + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver) #define dw_spi_ver_is(_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==)