| Message ID | 20220518170124.2849497-2-dlatypov@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77ce8ba3f069c10197bc354662eab09faa5693e2 |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | kunit: add support in kunit.py for --qemu_args | expand |
On Thu, May 19, 2022 at 1:01 AM Daniel Latypov <dlatypov@google.com> wrote: > > Without the quoting, the example will mess up invocations like > $ run_kunit "Something with spaces" > > Note: this example isn't valid, but if ever a usecase arises where a > flag argument might have spaces in it, it'll break. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> > --- Looks correct to me, though I'm not a bash _expert_. Reviewed-by: David Gow <davidgow@google.com> -- David > Documentation/dev-tools/kunit/running_tips.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst > index c36f6760087d..da8677c32aee 100644 > --- a/Documentation/dev-tools/kunit/running_tips.rst > +++ b/Documentation/dev-tools/kunit/running_tips.rst > @@ -15,7 +15,7 @@ It can be handy to create a bash function like: > .. code-block:: bash > > function run_kunit() { > - ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run $@ ) > + ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run "$@" ) > } > > .. note:: > -- > 2.36.1.124.g0e6072fb45-goog >
On Wed, May 18, 2022 at 1:01 PM Daniel Latypov <dlatypov@google.com> wrote: > > Without the quoting, the example will mess up invocations like > $ run_kunit "Something with spaces" > > Note: this example isn't valid, but if ever a usecase arises where a > flag argument might have spaces in it, it'll break. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst index c36f6760087d..da8677c32aee 100644 --- a/Documentation/dev-tools/kunit/running_tips.rst +++ b/Documentation/dev-tools/kunit/running_tips.rst @@ -15,7 +15,7 @@ It can be handy to create a bash function like: .. code-block:: bash function run_kunit() { - ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run $@ ) + ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run "$@" ) } .. note::
Without the quoting, the example will mess up invocations like $ run_kunit "Something with spaces" Note: this example isn't valid, but if ever a usecase arises where a flag argument might have spaces in it, it'll break. Signed-off-by: Daniel Latypov <dlatypov@google.com> --- Documentation/dev-tools/kunit/running_tips.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)