| Message ID | 20220706212855.1700615-1-deso@posteo.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add KIND_RESTRICT support to bpftool | expand |
On 06/07/2022 22:28, Daniel Müller wrote: > As pointed out in an earlier discussion [0] not all paths in bpftool's > minimization logic handle the restrict type qualifier properly. Specifically, > the gen min_core_btf command fails when encountering the corresponding BTF kind > for a TYPE_EXISTS relocation (TYPE_MATCHES support was added earlier): > > Error: unsupported kind: restrict (26) > > This patch set fixes this short coming. > > [0]: https://lore.kernel.org/bpf/20220623212205.2805002-1-deso@posteo.net/T/#m4c75205145701762a4b398e0cdb911d5b5305ffc > > Daniel Müller (2): > bpftool: Add support for KIND_RESTRICT to gen min_core_btf command > selftests/bpf: Add test involving restrict type qualifier > > tools/bpf/bpftool/gen.c | 1 + > tools/testing/selftests/bpf/prog_tests/core_reloc.c | 2 ++ > tools/testing/selftests/bpf/progs/core_reloc_types.h | 8 ++++++-- > .../selftests/bpf/progs/test_core_reloc_type_based.c | 5 +++++ > 4 files changed, 14 insertions(+), 2 deletions(-) > Acked-by: Quentin Monnet <quentin@isovalent.com> Thanks!
Hello: This series was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Wed, 6 Jul 2022 21:28:53 +0000 you wrote: > As pointed out in an earlier discussion [0] not all paths in bpftool's > minimization logic handle the restrict type qualifier properly. Specifically, > the gen min_core_btf command fails when encountering the corresponding BTF kind > for a TYPE_EXISTS relocation (TYPE_MATCHES support was added earlier): > > Error: unsupported kind: restrict (26) > > This patch set fixes this short coming. > > [...] Here is the summary with links: - [bpf-next,1/2] bpftool: Add support for KIND_RESTRICT to gen min_core_btf command https://git.kernel.org/bpf/bpf-next/c/aad53f17f0ad - [bpf-next,2/2] selftests/bpf: Add test involving restrict type qualifier https://git.kernel.org/bpf/bpf-next/c/32e0d9b31048 You are awesome, thank you!
As pointed out in an earlier discussion [0] not all paths in bpftool's minimization logic handle the restrict type qualifier properly. Specifically, the gen min_core_btf command fails when encountering the corresponding BTF kind for a TYPE_EXISTS relocation (TYPE_MATCHES support was added earlier): > Error: unsupported kind: restrict (26) This patch set fixes this short coming. [0]: https://lore.kernel.org/bpf/20220623212205.2805002-1-deso@posteo.net/T/#m4c75205145701762a4b398e0cdb911d5b5305ffc Daniel Müller (2): bpftool: Add support for KIND_RESTRICT to gen min_core_btf command selftests/bpf: Add test involving restrict type qualifier tools/bpf/bpftool/gen.c | 1 + tools/testing/selftests/bpf/prog_tests/core_reloc.c | 2 ++ tools/testing/selftests/bpf/progs/core_reloc_types.h | 8 ++++++-- .../selftests/bpf/progs/test_core_reloc_type_based.c | 5 +++++ 4 files changed, 14 insertions(+), 2 deletions(-)