| Message ID | 20220706114345.1128018-1-alexander.usyskin@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | GSC support for XeHP SDV and DG2 platforms | expand |
On Wed, Jul 06, 2022 at 02:43:31PM +0300, Alexander Usyskin wrote: > Add GSC support for XeHP SDV and DG2 platforms. > > The series includes changes for the mei driver: > - add ability to use polling instead of interrupts > - add ability to use extended timeouts > - setup extended operational memory for GSC > > The series includes changes for the i915 driver: > - allocate extended operational memory for GSC > - GSC on XeHP SDV offsets and definitions > > Greg KH, please review and ACK the MEI patches. > We are pushing these patches through gfx tree as > the auxiliary device belongs there. > > V2: rebase over merged DG1 series and DG2 enablement patch, > fix commit messages > > V3: rebase over latest tip > > V4: add missed changelog in pxp dbugfs patch > > V5: rebase over latest tip > fix changelog in pxp dbugfs patch > put HAX patch last to the ease of merging You did more than just this from v4 to v5 :( It's as if you want to make it hard to review these... greg k-h
On Fri, Jul 08, 2022 at 03:34:43PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 06, 2022 at 02:43:31PM +0300, Alexander Usyskin wrote: > > Add GSC support for XeHP SDV and DG2 platforms. > > > > The series includes changes for the mei driver: > > - add ability to use polling instead of interrupts > > - add ability to use extended timeouts > > - setup extended operational memory for GSC > > > > The series includes changes for the i915 driver: > > - allocate extended operational memory for GSC > > - GSC on XeHP SDV offsets and definitions > > > > Greg KH, please review and ACK the MEI patches. > > We are pushing these patches through gfx tree as > > the auxiliary device belongs there. > > > > V2: rebase over merged DG1 series and DG2 enablement patch, > > fix commit messages > > > > V3: rebase over latest tip > > > > V4: add missed changelog in pxp dbugfs patch > > > > V5: rebase over latest tip > > fix changelog in pxp dbugfs patch > > put HAX patch last to the ease of merging > > You did more than just this from v4 to v5 :( > > It's as if you want to make it hard to review these... I just checked the code and it looks the same to me. well, yeap, changing the order of other commits during the rebase was not mentioned. So we don't know the reason... But at least now the HAX is the last patch what makes more sense. But I don't believe this should block the review and require a v6 just to add this comment in the cover letter, or it should? Rodrigo. > > greg k-h
Add GSC support for XeHP SDV and DG2 platforms. The series includes changes for the mei driver: - add ability to use polling instead of interrupts - add ability to use extended timeouts - setup extended operational memory for GSC The series includes changes for the i915 driver: - allocate extended operational memory for GSC - GSC on XeHP SDV offsets and definitions Greg KH, please review and ACK the MEI patches. We are pushing these patches through gfx tree as the auxiliary device belongs there. V2: rebase over merged DG1 series and DG2 enablement patch, fix commit messages V3: rebase over latest tip V4: add missed changelog in pxp dbugfs patch V5: rebase over latest tip fix changelog in pxp dbugfs patch put HAX patch last to the ease of merging Alexander Usyskin (5): drm/i915/gsc: add slow_fw flag to the mei auxiliary device drm/i915/gsc: add slow_fw flag to the gsc device definition drm/i915/gsc: add GSC XeHP SDV platform definition mei: gsc: wait for reset thread on stop mei: extend timeouts on slow devices. Daniele Ceraolo Spurio (1): HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler (5): mei: gsc: use polling instead of interrupts mei: mkhi: add memory ready command mei: gsc: setup gsc extended operational memory mei: debugfs: add pxp mode to devstate in debugfs drm/i915/gsc: allocate extended operational memory in LMEM Vitaly Lubart (3): drm/i915/gsc: skip irq initialization if using polling mei: bus: export common mkhi definitions into a separate header mei: gsc: add transition to PXP mode in resume flow drivers/gpu/drm/i915/Kconfig.debug | 1 + drivers/gpu/drm/i915/gt/intel_gsc.c | 119 +++++++++++++++++++++++++--- drivers/gpu/drm/i915/gt/intel_gsc.h | 3 + drivers/misc/mei/bus-fixup.c | 105 ++++++++++++++++-------- drivers/misc/mei/client.c | 14 ++-- drivers/misc/mei/debugfs.c | 17 ++++ drivers/misc/mei/gsc-me.c | 77 +++++++++++++++--- drivers/misc/mei/hbm.c | 12 +-- drivers/misc/mei/hw-me-regs.h | 7 ++ drivers/misc/mei/hw-me.c | 116 ++++++++++++++++++++++----- drivers/misc/mei/hw-me.h | 14 +++- drivers/misc/mei/hw-txe.c | 2 +- drivers/misc/mei/hw.h | 5 ++ drivers/misc/mei/init.c | 21 ++++- drivers/misc/mei/main.c | 2 +- drivers/misc/mei/mei_dev.h | 26 ++++++ drivers/misc/mei/mkhi.h | 57 +++++++++++++ drivers/misc/mei/pci-me.c | 2 +- include/linux/mei_aux.h | 2 + 19 files changed, 511 insertions(+), 91 deletions(-) create mode 100644 drivers/misc/mei/mkhi.h