| Message ID | 20220707135532.1783925-1-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: forwarding: Install two missing tests | expand |
Hi Martin, On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote: > For some distributions (e.g. OpenWrt) we don't want to rely on rsync > to copy the tests to the target as some extra dependencies need to be > installed. The Makefile in tools/testing/selftests/net/forwarding > already installs most of the tests. > > This series adds the two missing tests to the list of installed tests. > That way a downstream distribution can build a package using this > Makefile (and add dependencies there as needed). Just for future reference, the netdev process is to mark patch sets such as this one with "PATCH net" since they fix a packaging problem with an rc kernel. There's more information about this in Documentation/process/maintainer-netdev.rst. Do we need to create a Makefile for the selftests symlinked by DSA in tools/testing/selftests/drivers/net/dsa/, for the symlinks to be installed, or how do you see this? The reason why I created the symlinks was to make use of the custom forwarding.config provided there, and also to reduce the clutter a bit and only focus on the selftests I felt were relevant for DSA for now.
Hi Vladimir, On Fri, Jul 8, 2022 at 12:25 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > Hi Martin, > > On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote: > > For some distributions (e.g. OpenWrt) we don't want to rely on rsync > > to copy the tests to the target as some extra dependencies need to be > > installed. The Makefile in tools/testing/selftests/net/forwarding > > already installs most of the tests. > > > > This series adds the two missing tests to the list of installed tests. > > That way a downstream distribution can build a package using this > > Makefile (and add dependencies there as needed). > > Just for future reference, the netdev process is to mark patch sets such > as this one with "PATCH net" since they fix a packaging problem with an > rc kernel. There's more information about this in > Documentation/process/maintainer-netdev.rst. noted > Do we need to create a Makefile for the selftests symlinked by DSA in > tools/testing/selftests/drivers/net/dsa/, for the symlinks to be > installed, or how do you see this? Yes, we should have a Makefile there as well (IMO). I'll send a patch for this. > The reason why I created the symlinks was to make use of the custom > forwarding.config provided there, and also to reduce the clutter a bit > and only focus on the selftests I felt were relevant for DSA for now. Makes sense, I'll make sure that this one is installed by the Makefile as well Best regards, Martin
Hello: This series was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 7 Jul 2022 15:55:30 +0200 you wrote: > For some distributions (e.g. OpenWrt) we don't want to rely on rsync > to copy the tests to the target as some extra dependencies need to be > installed. The Makefile in tools/testing/selftests/net/forwarding > already installs most of the tests. > > This series adds the two missing tests to the list of installed tests. > That way a downstream distribution can build a package using this > Makefile (and add dependencies there as needed). > > [...] Here is the summary with links: - [1/2] selftests: forwarding: Install local_termination.sh https://git.kernel.org/netdev/net/c/437ac2592c09 - [2/2] selftests: forwarding: Install no_forwarding.sh https://git.kernel.org/netdev/net/c/cfbba7b46aef You are awesome, thank you!