| Message ID | 20220629141000.18111-3-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: qcom: Add support for SC8280XP and SA8540P | expand |
On 29 June 2022 17:09:52 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote: >Fix the msi-interrupt conditional which always evaluated to false due to >a misspelled property name ("compatibles" in plural). > >Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >--- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >index ed9f9462a758..a1b4fc70e162 100644 >--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >@@ -628,7 +628,7 @@ allOf: > # On older chipsets it's always 1 msi interrupt > - if: > properties: >- compatibles: >+ compatible: > contains: > enum: > - qcom,pcie-msm8996
On 29/06/2022 16:09, Johan Hovold wrote: > Fix the msi-interrupt conditional which always evaluated to false due to > a misspelled property name ("compatibles" in plural). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 29/06/2022 17:09, Johan Hovold wrote: > Fix the msi-interrupt conditional which always evaluated to false due to > a misspelled property name ("compatibles" in plural). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index ed9f9462a758..a1b4fc70e162 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -628,7 +628,7 @@ allOf: > # On older chipsets it's always 1 msi interrupt > - if: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996
On 07/07/2022 16:34, Dmitry Baryshkov wrote: > On 29/06/2022 17:09, Johan Hovold wrote: >> Fix the msi-interrupt conditional which always evaluated to false due to >> a misspelled property name ("compatibles" in plural). >> >> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on > msm8996 platforms") Ugh, I was thinking about a different chunk (which also has this issue), so please ignore the Fixes. > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index ed9f9462a758..a1b4fc70e162 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -628,7 +628,7 @@ allOf: >> # On older chipsets it's always 1 msi interrupt >> - if: >> properties: >> - compatibles: >> + compatible: >> contains: >> enum: >> - qcom,pcie-msm8996 > >
On Thu, Jul 07, 2022 at 04:41:02PM +0300, Dmitry Baryshkov wrote: > On 07/07/2022 16:34, Dmitry Baryshkov wrote: > > On 29/06/2022 17:09, Johan Hovold wrote: > >> Fix the msi-interrupt conditional which always evaluated to false due to > >> a misspelled property name ("compatibles" in plural). > >> > >> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on > > msm8996 platforms") > > Ugh, I was thinking about a different chunk (which also has this issue), > so please ignore the Fixes. Heh, yeah, I was pretty I had already added it for the issue in mainline. Johan
On Wed, Jun 29, 2022 at 04:09:52PM +0200, Johan Hovold wrote: > Fix the msi-interrupt conditional which always evaluated to false due to > a misspelled property name ("compatibles" in plural). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index ed9f9462a758..a1b4fc70e162 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -628,7 +628,7 @@ allOf: > # On older chipsets it's always 1 msi interrupt > - if: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996 > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index ed9f9462a758..a1b4fc70e162 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -628,7 +628,7 @@ allOf: # On older chipsets it's always 1 msi interrupt - if: properties: - compatibles: + compatible: contains: enum: - qcom,pcie-msm8996
Fix the msi-interrupt conditional which always evaluated to false due to a misspelled property name ("compatibles" in plural). Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)