| Message ID | b3b78926569445962ea5c3b6e9102418a9effb88.1656155715.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] memstick/ms_block: Fix some incorrect memory allocation | expand |
On Sat, 25 Jun 2022 at 14:55, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'erased_blocks_bitmap' is never freed. As it is allocated at the same time > as 'used_blocks_bitmap', it is likely that it should be freed also at the > same time. > > Add the corresponding bitmap_free() in msb_data_clear(). > > Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied for next, thanks! Kind regards Uffe > --- > This patch is speculative. > --- > drivers/memstick/core/ms_block.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c > index f8f151163667..f8fdf88fb240 100644 > --- a/drivers/memstick/core/ms_block.c > +++ b/drivers/memstick/core/ms_block.c > @@ -1947,6 +1947,7 @@ static void msb_data_clear(struct msb_data *msb) > { > kfree(msb->boot_page); > bitmap_free(msb->used_blocks_bitmap); > + bitmap_free(msb->erased_blocks_bitmap); > kfree(msb->lba_to_pba_table); > kfree(msb->cache); > msb->card = NULL; > -- > 2.34.1 >
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index f8f151163667..f8fdf88fb240 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -1947,6 +1947,7 @@ static void msb_data_clear(struct msb_data *msb) { kfree(msb->boot_page); bitmap_free(msb->used_blocks_bitmap); + bitmap_free(msb->erased_blocks_bitmap); kfree(msb->lba_to_pba_table); kfree(msb->cache); msb->card = NULL;
'erased_blocks_bitmap' is never freed. As it is allocated at the same time as 'used_blocks_bitmap', it is likely that it should be freed also at the same time. Add the corresponding bitmap_free() in msb_data_clear(). Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is speculative. --- drivers/memstick/core/ms_block.c | 1 + 1 file changed, 1 insertion(+)