| Message ID | 20220708183210.1334839-2-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/3] thermal/core: Encapsulate the trip point crossed function | expand |
On 7/8/22 19:32, Daniel Lezcano wrote: > As the trip temperature is already available when calling the > function, pass it as a parameter instead of having the function > calling the ops again to retrieve the same data. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/thermal_core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index d9f771b15ed8..f66036b3daae 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct thermal_zone_device *tz) > EXPORT_SYMBOL(thermal_zone_device_critical); > > static void handle_critical_trips(struct thermal_zone_device *tz, > - int trip, enum thermal_trip_type trip_type) > + int trip, int trip_temp, enum thermal_trip_type trip_type) > { > - int trip_temp; > - > - tz->ops->get_trip_temp(tz, trip, &trip_temp); > - > /* If we have not crossed the trip_temp, we do not care. */ > if (trip_temp <= 0 || tz->temperature < trip_temp) > return; > @@ -394,7 +390,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) > handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type); > > if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT) > - handle_critical_trips(tz, trip, type); > + handle_critical_trips(tz, trip, trip_temp, type); > else > handle_non_critical_trips(tz, trip); > /* Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
On Fri, Jul 8, 2022 at 8:32 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > As the trip temperature is already available when calling the > function, Which function? I would change the subject to something like "Avoid calling ->get_trip_temp() unnecessarily" and then use the specific function name in the changelog. The changes themselves LGTM. > pass it as a parameter instead of having the function > calling the ops again to retrieve the same data. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/thermal_core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index d9f771b15ed8..f66036b3daae 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct thermal_zone_device *tz) > EXPORT_SYMBOL(thermal_zone_device_critical); > > static void handle_critical_trips(struct thermal_zone_device *tz, > - int trip, enum thermal_trip_type trip_type) > + int trip, int trip_temp, enum thermal_trip_type trip_type) > { > - int trip_temp; > - > - tz->ops->get_trip_temp(tz, trip, &trip_temp); > - > /* If we have not crossed the trip_temp, we do not care. */ > if (trip_temp <= 0 || tz->temperature < trip_temp) > return; > @@ -394,7 +390,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) > handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type); > > if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT) > - handle_critical_trips(tz, trip, type); > + handle_critical_trips(tz, trip, trip_temp, type); > else > handle_non_critical_trips(tz, trip); > /* > -- > 2.25.1 >
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index d9f771b15ed8..f66036b3daae 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct thermal_zone_device *tz) EXPORT_SYMBOL(thermal_zone_device_critical); static void handle_critical_trips(struct thermal_zone_device *tz, - int trip, enum thermal_trip_type trip_type) + int trip, int trip_temp, enum thermal_trip_type trip_type) { - int trip_temp; - - tz->ops->get_trip_temp(tz, trip, &trip_temp); - /* If we have not crossed the trip_temp, we do not care. */ if (trip_temp <= 0 || tz->temperature < trip_temp) return; @@ -394,7 +390,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type); if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT) - handle_critical_trips(tz, trip, type); + handle_critical_trips(tz, trip, trip_temp, type); else handle_non_critical_trips(tz, trip); /*
As the trip temperature is already available when calling the function, pass it as a parameter instead of having the function calling the ops again to retrieve the same data. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/thermal/thermal_core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)