diff mbox series

[net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

Message ID 324a31644b29f7211edb13f26b5ad9ab69a7f0e9.1656422252.git.thomas.lendacky@amd.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Tom Lendacky June 28, 2022, 1:17 p.m. UTC
Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
network device driver.

Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Perches June 28, 2022, 5:37 p.m. UTC | #1
On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
> network device driver.
> 
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>  
>  AMD XGBE DRIVER
>  M:	Tom Lendacky <thomas.lendacky@amd.com>
> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

While this is a valid email address, get_maintainer assumes
name formats use "first middle last" when parsing a name
before an email address. (look around line 2460 in get_maintainer)

Perhaps this should use quotes around the name like:

M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Tom Lendacky July 13, 2022, 10:07 p.m. UTC | #2
On 6/28/22 12:37, Joe Perches wrote:
> On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
>> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
>> network device driver.
>>
>> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>>   
>>   AMD XGBE DRIVER
>>   M:	Tom Lendacky <thomas.lendacky@amd.com>
>> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> 
> While this is a valid email address, get_maintainer assumes
> name formats use "first middle last" when parsing a name
> before an email address. (look around line 2460 in get_maintainer)
> 
> Perhaps this should use quotes around the name like:
> 
> M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>

Totally lost this in my Inbox, I'll submit a v2 with the quotes.

Thanks,
Tom

> 
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 36f0a205c54a..02e0d0464312 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1037,6 +1037,7 @@  F:	arch/arm64/boot/dts/amd/
 
 AMD XGBE DRIVER
 M:	Tom Lendacky <thomas.lendacky@amd.com>
+M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi