| Message ID | 20220707134725.3512-17-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom,qmp: fix dt-bindings and deprecate lane suffix | expand |
On 07/07/2022 15:47, Johan Hovold wrote: > Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the > binding. > > Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") > Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") The second fixes seems not appropriate here, because you are not fixing a DTS. A fix for DTS would be a fix for that one. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Jul 14, 2022 at 11:21:52AM +0200, Krzysztof Kozlowski wrote: > On 07/07/2022 15:47, Johan Hovold wrote: > > Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the > > binding. > > > > Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") > > Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") > > The second fixes seems not appropriate here, because you are not fixing > a DTS. A fix for DTS would be a fix for that one. I wanted to highlight the fact the binding wasn't amended when the DTS started using the new clock, which it should have. But sure, that would have gone in a separate patch. I can replace the second Fixes with a Link to the dts submission as a reference instead. Johan
On 14/07/2022 12:07, Johan Hovold wrote: > On Thu, Jul 14, 2022 at 11:21:52AM +0200, Krzysztof Kozlowski wrote: >> On 07/07/2022 15:47, Johan Hovold wrote: >>> Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the >>> binding. >>> >>> Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") >>> Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") >> >> The second fixes seems not appropriate here, because you are not fixing >> a DTS. A fix for DTS would be a fix for that one. > > I wanted to highlight the fact the binding wasn't amended when the DTS > started using the new clock, which it should have. But sure, that would > have gone in a separate patch. I can replace the second Fixes with a > Link to the dts submission as a reference instead. Yes, that or mentioning as "commit xxx ..." in msg would be better. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index e9dfed29e996..7a1f80e2cf23 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -42,11 +42,11 @@ properties: clocks: minItems: 1 - maxItems: 2 + maxItems: 3 clock-names: minItems: 1 - maxItems: 2 + maxItems: 3 resets: maxItems: 1 @@ -117,6 +117,22 @@ allOf: - const: ref - const: ref_aux + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8450-qmp-ufs-phy + then: + properties: + clocks: + maxItems: 3 + clock-names: + items: + - const: ref + - const: ref_aux + - const: qref + examples: - | #include <dt-bindings/clock/qcom,gcc-sc8280xp.h>
Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the binding. Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)