| Message ID | 20220713133953.595134-1-fabrice.gasnier@foss.st.com |
|---|---|
| State | Accepted |
| Commit | 32b378a9179ae4db61cfc5d502717214e6cd1e1c |
| Headers | show |
| Series | phy: stm32: fix error return in stm32_usbphyc_phy_init | expand |
On 13-07-22, 15:39, Fabrice Gasnier wrote: > Error code is overridden, in case the PLL doesn't lock. So, the USB > initialization can continue. This leads to a platform freeze. > This can be avoided by returning proper error code to avoid USB probe > freezing the platform. It also displays proper errors in log. Applied, thanks
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 007a23c78d562..a98c911cc37ae 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -358,7 +358,9 @@ static int stm32_usbphyc_phy_init(struct phy *phy) return 0; pll_disable: - return stm32_usbphyc_pll_disable(usbphyc); + stm32_usbphyc_pll_disable(usbphyc); + + return ret; } static int stm32_usbphyc_phy_exit(struct phy *phy)
Error code is overridden, in case the PLL doesn't lock. So, the USB initialization can continue. This leads to a platform freeze. This can be avoided by returning proper error code to avoid USB probe freezing the platform. It also displays proper errors in log. Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection") Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> --- drivers/phy/st/phy-stm32-usbphyc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)