| Message ID | 20220715061027.1612149-7-kaleshsingh@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM nVHE Hypervisor stack unwinder | expand |
Hi Kalesh, On Fri, Jul 15, 2022 at 7:11 AM Kalesh Singh <kaleshsingh@google.com> wrote: > > Add brief description on how to use stacktrace/common.h to implement > a stack unwinder. > > Signed-off-by: Kalesh Singh <kaleshsingh@google.com> > --- > arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h > index f86efe71479d..b362086f4c70 100644 > --- a/arch/arm64/include/asm/stacktrace/common.h > +++ b/arch/arm64/include/asm/stacktrace/common.h > @@ -2,6 +2,14 @@ > /* > * Common arm64 stack unwinder code. > * > + * To implement a new arm64 stack unwinder: > + * 1) Include this header > + * > + * 2) Provide implementations for the following functions: > + * - on_overflow_stack() > + * - on_accessible_stack() > + * - unwind_next() > + * > * Copyright (C) 2012 ARM Ltd. > */ > #ifndef __ASM_STACKTRACE_COMMON_H > -- Ideally it would be nice to have a description of what these functions are expected to do, but that said, Reviewed-by: Fuad Tabba <tabba@google.com> Thanks, /fuad > 2.37.0.170.g444d1eabd0-goog >
On Fri, 15 Jul 2022 07:10:15 +0100, Kalesh Singh <kaleshsingh@google.com> wrote: > > Add brief description on how to use stacktrace/common.h to implement > a stack unwinder. > > Signed-off-by: Kalesh Singh <kaleshsingh@google.com> > --- > arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h > index f86efe71479d..b362086f4c70 100644 > --- a/arch/arm64/include/asm/stacktrace/common.h > +++ b/arch/arm64/include/asm/stacktrace/common.h > @@ -2,6 +2,14 @@ > /* > * Common arm64 stack unwinder code. > * > + * To implement a new arm64 stack unwinder: > + * 1) Include this header > + * > + * 2) Provide implementations for the following functions: > + * - on_overflow_stack() > + * - on_accessible_stack() > + * - unwind_next() A short description of what these helpers are supposed to do would also be helpful. Thanks, M.
On Sun, Jul 17, 2022 at 2:58 AM Marc Zyngier <maz@kernel.org> wrote: > > On Fri, 15 Jul 2022 07:10:15 +0100, > Kalesh Singh <kaleshsingh@google.com> wrote: > > > > Add brief description on how to use stacktrace/common.h to implement > > a stack unwinder. > > > > Signed-off-by: Kalesh Singh <kaleshsingh@google.com> > > --- > > arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h > > index f86efe71479d..b362086f4c70 100644 > > --- a/arch/arm64/include/asm/stacktrace/common.h > > +++ b/arch/arm64/include/asm/stacktrace/common.h > > @@ -2,6 +2,14 @@ > > /* > > * Common arm64 stack unwinder code. > > * > > + * To implement a new arm64 stack unwinder: > > + * 1) Include this header > > + * > > + * 2) Provide implementations for the following functions: > > + * - on_overflow_stack() > > + * - on_accessible_stack() > > + * - unwind_next() > > A short description of what these helpers are supposed to do would > also be helpful. Thanks Fuad, Marc. I'll add descriptions in the next version. > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.
diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h index f86efe71479d..b362086f4c70 100644 --- a/arch/arm64/include/asm/stacktrace/common.h +++ b/arch/arm64/include/asm/stacktrace/common.h @@ -2,6 +2,14 @@ /* * Common arm64 stack unwinder code. * + * To implement a new arm64 stack unwinder: + * 1) Include this header + * + * 2) Provide implementations for the following functions: + * - on_overflow_stack() + * - on_accessible_stack() + * - unwind_next() + * * Copyright (C) 2012 ARM Ltd. */ #ifndef __ASM_STACKTRACE_COMMON_H
Add brief description on how to use stacktrace/common.h to implement a stack unwinder. Signed-off-by: Kalesh Singh <kaleshsingh@google.com> --- arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ 1 file changed, 8 insertions(+)