diff mbox series

[mvebu/dt,1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity

Message ID 20220704113622.18887-1-kabel@kernel.org (mailing list archive)
State New, archived
Headers show
Series [mvebu/dt,1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity | expand

Commit Message

Marek Behún July 4, 2022, 11:36 a.m. UTC
The marvell PHY driver changes the LED[0] pin function to "On - 1000
Mbps Link, Off - Else".

Turris Omnia expects that the function is "On - Link, Blink - Activity,
Off - No link".

Use the `marvell,reg-init` DT property to change the function.

In the future, once netdev trigger will support HW offloading, we will
be able to have this configured via the combination of PHY driver and
leds-turris-omnia driver.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gregory CLEMENT July 18, 2022, 10:42 a.m. UTC | #1
Marek Behún <kabel@kernel.org> writes:

> The marvell PHY driver changes the LED[0] pin function to "On - 1000
> Mbps Link, Off - Else".
>
> Turris Omnia expects that the function is "On - Link, Blink - Activity,
> Off - No link".
>
> Use the `marvell,reg-init` DT property to change the function.
>
> In the future, once netdev trigger will support HW offloading, we will
> be able to have this configured via the combination of PHY driver and
> leds-turris-omnia driver.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4878df39753..1583c4b14ae8 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -397,7 +397,8 @@ &mdio {
>  	phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		marvell,reg-init = <3 18 0 0x4985>;
> +		marvell,reg-init = <3 18 0 0x4985>,
> +				   <3 16 0xfff0 0x0001>;
>  
>  		/* irq is connected to &pcawan pin 7 */
>  	};
> -- 
> 2.35.1
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f4878df39753..1583c4b14ae8 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -397,7 +397,8 @@  &mdio {
 	phy1: ethernet-phy@1 {
 		compatible = "ethernet-phy-ieee802.3-c22";
 		reg = <1>;
-		marvell,reg-init = <3 18 0 0x4985>;
+		marvell,reg-init = <3 18 0 0x4985>,
+				   <3 16 0xfff0 0x0001>;
 
 		/* irq is connected to &pcawan pin 7 */
 	};