| Message ID | 20220718052217.29729-1-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: mediatek: dpi: add power-domains property | expand |
Il 18/07/22 07:22, Allen-KH Cheng ha scritto: > DPI is part of the display / multimedia block in MediaTek SoCs > and is managed using power controller in some platforms. We add > the power-domains property to the binding documentation. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> For the contents of this commit: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ...but I'm not sure whether this one requires a Fixes tag (because, effectively, the DPI hardware *requires* that power domain to get up) - and if it does, which commit to reference: the first commit for this file is a TXT->schema conversion, but the TXT didn't have power-domains as well. Regards, Angelo
Hi Angelo, On Mon, 2022-07-18 at 15:59 +0200, AngeloGioacchino Del Regno wrote: > Il 18/07/22 07:22, Allen-KH Cheng ha scritto: > > DPI is part of the display / multimedia block in MediaTek SoCs > > and is managed using power controller in some platforms. We add > > the power-domains property to the binding documentation. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > For the contents of this commit: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > > ...but I'm not sure whether this one requires a Fixes tag (because, > effectively, > the DPI hardware *requires* that power domain to get up) - and if it > does, > which commit to reference: the first commit for this file is a TXT- > >schema > conversion, but the TXT didn't have power-domains as well. > > > > Regards, > Angelo For commit 9273cf7d3 "convert the dpi bindings to yaml" We add mt8173-dpi compatible but there is no power-domains property in binding doc. Yes, I think it should be added Fixes tag. Thanks for your suggestion. Best Regards, Allen
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 5bb23e97cf33..9f012afdf19b 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -58,6 +58,9 @@ properties: Output port node. This port should be connected to the input port of an attached HDMI, LVDS or DisplayPort encoder chip. + power-domains: + maxItems: 1 + required: - compatible - reg @@ -72,11 +75,13 @@ examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/mt8173-clk.h> + #include <dt-bindings/power/mt8173-power.h> dpi0: dpi@1401d000 { compatible = "mediatek,mt8173-dpi"; reg = <0x1401d000 0x1000>; interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; clocks = <&mmsys CLK_MM_DPI_PIXEL>, <&mmsys CLK_MM_DPI_ENGINE>, <&apmixedsys CLK_APMIXED_TVDPLL>;
DPI is part of the display / multimedia block in MediaTek SoCs and is managed using power controller in some platforms. We add the power-domains property to the binding documentation. Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++ 1 file changed, 5 insertions(+)