| Message ID | 20220714120217.18635-1-lukasz.spintzyk@synaptics.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices | expand |
On Thu, Jul 14, 2022 at 02:02:16PM +0200, Łukasz Spintzyk wrote: > From: Dominik Czerwik <dominik.czerwik@synaptics.com> > > This improves performance and stability of > DL-3xxx/DL-5xxx/DL-6xxx device series. > > Specifically prevents device from temporary network dropouts when > playing video from the web and network traffic going through is high. > > Signed-off-by: Bernice Chen <Bernice.Chen@synaptics.com> > Signed-off-by: Dominik Czerwik <dominik.czerwik@synaptics.com> > Signed-off-by: Łukasz Spintzyk <lukasz.spintzyk@synaptics.com> > --- > > v2: Added Bernice Chen as company lawyer. You forgot to cc: them, as they obviously want to be involved in this process. They do understand what Signed-off-by: means, right? > > drivers/net/usb/cdc_ncm.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index d55f59ce4a31..4594bf2982ee 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -2,6 +2,7 @@ > * cdc_ncm.c > * > * Copyright (C) ST-Ericsson 2010-2012 > + * Copyright (C) 2022 Synaptics Incorporated. All rights reserved. Bernice, please note that Dominik is only adding 23 lines to a 2039 line file, making this a change that only affects a very small percentage of the overall code, and affects the logic in no direct way (they are only adding new device information.) Based on that information, you still believe this warrents an addition of a copyright notice? Any pointers to legal rulings where this is backed up would be appreciated as it goes against what I have been told to allow by my lawyers. thanks, greg k-h
On 14.07.22 14:02, Łukasz Spintzyk wrote: > From: Dominik Czerwik <dominik.czerwik@synaptics.com> > > This improves performance and stability of > DL-3xxx/DL-5xxx/DL-6xxx device series. > Hi, may I request that you send an additional patch changing the description of cdc_ncm_info, so that is clear that it does not send ZLP, in contrast to the new option? Regards Oliver
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index d55f59ce4a31..4594bf2982ee 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -2,6 +2,7 @@ * cdc_ncm.c * * Copyright (C) ST-Ericsson 2010-2012 + * Copyright (C) 2022 Synaptics Incorporated. All rights reserved. * Contact: Alexey Orishko <alexey.orishko@stericsson.com> * Original author: Hans Petter Selasky <hans.petter.selasky@stericsson.com> * @@ -1904,6 +1905,19 @@ static const struct driver_info cdc_ncm_info = { .set_rx_mode = usbnet_cdc_update_filter, }; +/* Same as cdc_ncm_info, but with FLAG_SEND_ZLP */ +static const struct driver_info cdc_ncm_zlp_info = { + .description = "CDC NCM (SEND ZLP)", + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET + | FLAG_LINK_INTR | FLAG_ETHER | FLAG_SEND_ZLP, + .bind = cdc_ncm_bind, + .unbind = cdc_ncm_unbind, + .manage_power = usbnet_manage_power, + .status = cdc_ncm_status, + .rx_fixup = cdc_ncm_rx_fixup, + .tx_fixup = cdc_ncm_tx_fixup, +}; + /* Same as cdc_ncm_info, but with FLAG_WWAN */ static const struct driver_info wwan_info = { .description = "Mobile Broadband Network Device", @@ -2010,6 +2024,16 @@ static const struct usb_device_id cdc_devs[] = { .driver_info = (unsigned long)&wwan_info, }, + /* DisplayLink docking stations */ + { .match_flags = USB_DEVICE_ID_MATCH_INT_INFO + | USB_DEVICE_ID_MATCH_VENDOR, + .idVendor = 0x17e9, + .bInterfaceClass = USB_CLASS_COMM, + .bInterfaceSubClass = USB_CDC_SUBCLASS_NCM, + .bInterfaceProtocol = USB_CDC_PROTO_NONE, + .driver_info = (unsigned long)&cdc_ncm_zlp_info, + }, + /* Generic CDC-NCM devices */ { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),