| Message ID | YtflxRosxskh2CoH@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3c7ec89ab45e7a46b806910de78d7243a114a860 |
| Headers | show |
| Series | Bluetooth: clean up error pointer checking | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | success | PASS |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661424 ---Test result--- Test Summary: CheckPatch PASS 1.37 seconds GitLint PASS 0.56 seconds SubjectPrefix PASS 0.30 seconds BuildKernel PASS 45.84 seconds BuildKernel32 PASS 40.97 seconds Incremental Build with patchesPASS 69.34 seconds TestRunner: Setup PASS 676.66 seconds TestRunner: l2cap-tester PASS 19.85 seconds TestRunner: bnep-tester PASS 7.13 seconds TestRunner: mgmt-tester PASS 118.69 seconds TestRunner: rfcomm-tester PASS 11.35 seconds TestRunner: sco-tester PASS 11.69 seconds TestRunner: smp-tester PASS 11.14 seconds TestRunner: userchan-tester PASS 7.73 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 20 Jul 2022 14:23:49 +0300 you wrote: > The bt_skb_sendmsg() function can't return NULL so there is no need to > check for that. Several of these checks were removed previously but > this one was missed. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > include/net/bluetooth/bluetooth.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - Bluetooth: clean up error pointer checking https://git.kernel.org/bluetooth/bluetooth-next/c/3c7ec89ab45e You are awesome, thank you!
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h index 6b48d9e2aab9..a8b52175af05 100644 --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetooth.h @@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk, struct sk_buff *skb, **frag; skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom); - if (IS_ERR_OR_NULL(skb)) + if (IS_ERR(skb)) return skb; len -= skb->len;
The bt_skb_sendmsg() function can't return NULL so there is no need to check for that. Several of these checks were removed previously but this one was missed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- include/net/bluetooth/bluetooth.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)