| Message ID | 20220721121454.1378945-1-cristian.ciocaltea@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: cs35l41: Set the new legacy DAI naming flag | expand |
On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote: > Unlike most CODEC drivers, the CS35L41 driver did not have the > non_legacy_dai_naming set, meaning it uses the legacy naming. > > The recent migration to the new legacy DAI naming style has broken > driver functionality because it is now expected to set the new legacy > DAI naming flag in order to instruct the core subsystem to use the > legacy name format on DAI registration. > > Let's fix this by setting the legacy_dai_naming flag accordingly. > > Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag") > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- It is really not intended for any CODECs to be using the legacy DAI naming, it was only intended for platform side components. Would be good if you had some details on the affected system and if that could be updated to use the non legacy DAI naming? Thanks, Charles
Hi Charles, On 7/21/22 16:19, Charles Keepax wrote: > On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote: >> Unlike most CODEC drivers, the CS35L41 driver did not have the >> non_legacy_dai_naming set, meaning it uses the legacy naming. >> >> The recent migration to the new legacy DAI naming style has broken >> driver functionality because it is now expected to set the new legacy >> DAI naming flag in order to instruct the core subsystem to use the >> legacy name format on DAI registration. >> >> Let's fix this by setting the legacy_dai_naming flag accordingly. >> >> Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag") >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- > > It is really not intended for any CODECs to be using the legacy > DAI naming, it was only intended for platform side components. > Would be good if you had some details on the affected system and > if that could be updated to use the non legacy DAI naming? I'm currently testing this on Valve's Steam Deck. Let me also check what would be the required changes in order to switch to using a non-legacy DAI naming. > Thanks, > Charles
On 7/21/22 17:54, Cristian Ciocaltea wrote: > Hi Charles, > > On 7/21/22 16:19, Charles Keepax wrote: >> On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote: >>> Unlike most CODEC drivers, the CS35L41 driver did not have the >>> non_legacy_dai_naming set, meaning it uses the legacy naming. >>> >>> The recent migration to the new legacy DAI naming style has broken >>> driver functionality because it is now expected to set the new legacy >>> DAI naming flag in order to instruct the core subsystem to use the >>> legacy name format on DAI registration. >>> >>> Let's fix this by setting the legacy_dai_naming flag accordingly. >>> >>> Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag") >>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >>> --- >> >> It is really not intended for any CODECs to be using the legacy >> DAI naming, it was only intended for platform side components. >> Would be good if you had some details on the affected system and >> if that could be updated to use the non legacy DAI naming? > > I'm currently testing this on Valve's Steam Deck. Let me also check what > would be the required changes in order to switch to using a non-legacy > DAI naming. I have just submitted a (proper) fix: https://lore.kernel.org/all/20220721233227.1459374-1-cristian.ciocaltea@collabora.com/ Thanks, Cristian >> Thanks, >> Charles >
diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c index c223d83e02cf..b49f9a32abf2 100644 --- a/sound/soc/codecs/cs35l41.c +++ b/sound/soc/codecs/cs35l41.c @@ -1028,6 +1028,7 @@ static const struct snd_soc_component_driver soc_component_dev_cs35l41 = { .set_sysclk = cs35l41_component_set_sysclk, .endianness = 1, + .legacy_dai_naming = 1, }; static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cfg)
Unlike most CODEC drivers, the CS35L41 driver did not have the non_legacy_dai_naming set, meaning it uses the legacy naming. The recent migration to the new legacy DAI naming style has broken driver functionality because it is now expected to set the new legacy DAI naming flag in order to instruct the core subsystem to use the legacy name format on DAI registration. Let's fix this by setting the legacy_dai_naming flag accordingly. Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- sound/soc/codecs/cs35l41.c | 1 + 1 file changed, 1 insertion(+) -- 2.37.1