| Message ID | 20220706210454.30096-9-dpsmith@apertussolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Hyperlaunch | expand |
Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 08/18] kconfig: introduce domain builder config option > > Hyperlaunch domain builder is the consolidated boot time domain building > logic > framework. This commit introduces the first config option for the domain > builder to control support for loading the domain configurations via the > flattened device tree. > > Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com> > Reviewed-by: Christopher Clark <christopher.clark@starlab.io> Reviewed-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry > --- > xen/common/Kconfig | 1 + > xen/common/domain-builder/Kconfig | 15 +++++++++++++++
On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/common/domain-builder/Kconfig > @@ -0,0 +1,15 @@ > + > +menu "Domain Builder Features" > + > +config BUILDER_FDT > + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED > + select CORE_DEVICE_TREE > + ---help--- Nit: No new ---help--- please anymore. > + Enables the ability to configure the domain builder using a > + flattened device tree. Is this about both Dom0 and DomU? Especially if not, this wants making explicit. But perhaps even if so it wants saying, for the avoidance of doubt. Jan
On 7/19/22 09:29, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/common/domain-builder/Kconfig >> @@ -0,0 +1,15 @@ >> + >> +menu "Domain Builder Features" >> + >> +config BUILDER_FDT >> + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED >> + select CORE_DEVICE_TREE >> + ---help--- > > Nit: No new ---help--- please anymore. Ack. >> + Enables the ability to configure the domain builder using a >> + flattened device tree. > > Is this about both Dom0 and DomU? Especially if not, this wants making > explicit. But perhaps even if so it wants saying, for the avoidance of > doubt. The following patches will end with full conversion of both Dom0 and DomU construction to be handled by a core domain construction framework. If a device tree configuration is not present or this Kconfig option is not set, then the domain builder will construct a Dom0 as it does today. Turning this option on enables controlling the domain builder using a device tree configuration, which (eventually) will be able to construct any combination of Dom0, HWDom, CtlDom, DomU, etc. So I can add a qualifier of, 'configure what domains will be constructed at boot by the domain builder using a flattened device tree'. I can even add an explanation that on x86 the FDT must be provided as the first multiboot module. v/r, dps
diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 9fc6683932..5a1c40e392 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -355,6 +355,7 @@ config ARGO If unsure, say N. +source "common/domain-builder/Kconfig" source "common/sched/Kconfig" config CRYPTO diff --git a/xen/common/domain-builder/Kconfig b/xen/common/domain-builder/Kconfig new file mode 100644 index 0000000000..893038cab3 --- /dev/null +++ b/xen/common/domain-builder/Kconfig @@ -0,0 +1,15 @@ + +menu "Domain Builder Features" + +config BUILDER_FDT + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED + select CORE_DEVICE_TREE + ---help--- + Enables the ability to configure the domain builder using a + flattened device tree. + + This feature is currently experimental. + + If unsure, say N. + +endmenu