| Message ID | 20220722141705.3340440-1-venkataprasad.potturu@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: amd: acp: Modify dai_id macros to be more generic | expand |
On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote: > Update dai_id macros to make code generic for all platforms. > -#define I2S_SP_INSTANCE 0x00 > -#define I2S_BT_INSTANCE 0x01 > -#define DMIC_INSTANCE 0x02 > +#define DMIC_INSTANCE 0x00 > +#define I2S_SP_INSTANCE 0x01 > +#define I2S_BT_INSTANCE 0x02 This looks like it's just an indentation/formatting change which isn't what the changelog said?
[AMD Official Use Only - General] On 7/22/2022 8:22 PM, Mark Brown wrote: Thanks for your time. On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote: Update dai_id macros to make code generic for all platforms. -#define I2S_SP_INSTANCE 0x00 -#define I2S_BT_INSTANCE 0x01 -#define DMIC_INSTANCE 0x02 +#define DMIC_INSTANCE 0x00 +#define I2S_SP_INSTANCE 0x01 +#define I2S_BT_INSTANCE 0x02 This looks like it's just an indentation/formatting change which isn't what the changelog said? We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances. To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02. I2S_HS_INSTANCE is already 0x03.
On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote: > This looks like it's just an indentation/formatting change which isn't > > what the changelog said? > We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances. > > To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02. > I2S_HS_INSTANCE is already 0x03. Please write a better changelog which makes this clear. Please fix your e-mail client to clearly distinguish between quoted and non-quoted text, it's very hard to find your new text in your mail.
On 7/25/22 17:32, Mark Brown wrote: Thanks for your time. > On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote: > >> This looks like it's just an indentation/formatting change which isn't >> >> what the changelog said? >> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances. >> >> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02. >> I2S_HS_INSTANCE is already 0x03. > Please write a better changelog which makes this clear. Okay, we will change accordingly. > > Please fix your e-mail client to clearly distinguish between quoted and > non-quoted text, it's very hard to find your new text in your mail.
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 148a9ab6206d..ff2fb476fa6c 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -21,9 +21,9 @@ #define ACP3X_DEV 3 #define ACP6X_DEV 6 -#define I2S_SP_INSTANCE 0x00 -#define I2S_BT_INSTANCE 0x01 -#define DMIC_INSTANCE 0x02 +#define DMIC_INSTANCE 0x00 +#define I2S_SP_INSTANCE 0x01 +#define I2S_BT_INSTANCE 0x02 #define I2S_HS_INSTANCE 0x03 #define MEM_WINDOW_START 0x4080000
Update dai_id macros to make code generic for all platforms. Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com> --- sound/soc/amd/acp/amd.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)