| Message ID | 20220722105345.175-1-13691752556@139.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7209344223f77311aee677ea820a93b9ba0bcae0 |
| Headers | show |
| Series | [v7] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx | expand |
On Fri, Jul 22, 2022 at 06:53:45PM +0800, Raphael-Xu wrote: > remove tas2780 Your commit message needs to answer 'why'? Write complete sentences. Though as this was just added, you should do 'git revert' and send that patch. And this is not v7. > Signed-off-by: Raphael-Xu <13691752556@139.com> > --- > .../devicetree/bindings/sound/tas2780.yaml | 75 ------------------- > 1 file changed, 75 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml However, Mark took the original patch with the same issues, so: Acked-by: Rob Herring <robh@kernel.org>
On Mon, Jul 25, 2022 at 04:49:19PM -0600, Rob Herring wrote: > On Fri, Jul 22, 2022 at 06:53:45PM +0800, Raphael-Xu wrote: > > remove tas2780 > > Your commit message needs to answer 'why'? Write complete sentences. > > Though as this was just added, you should do 'git revert' and send that > patch. But please write a proper subject and commit description with signoff and so on, it's still a patch even if you generate the initial content with revert.
On Fri, Jul 22, 2022 at 06:53:45PM +0800, Raphael-Xu wrote: > remove tas2780 > > Signed-off-by: Raphael-Xu <13691752556@139.com> > --- > .../devicetree/bindings/sound/tas2780.yaml | 75 ------------------- > 1 file changed, 75 deletions(-) The file upstream is 72 lines long... I fixed things up this time but in general please make sure you're submitting patches that can be applied to the tree you want them applying to.
On Fri, 22 Jul 2022 18:53:45 +0800, Raphael-Xu wrote: > remove tas2780 > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx commit: 7209344223f77311aee677ea820a93b9ba0bcae0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/tas2780.yaml b/Documentation/devicetree/bindings/sound/tas2780.yaml deleted file mode 100644 index 21389a16fdb9..000000000000 --- a/Documentation/devicetree/bindings/sound/tas2780.yaml +++ /dev/null @@ -1,75 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -# Copyright (C) 2020-2022 Texas Instruments Incorporated -%YAML 1.2 ---- -$id: "http://devicetree.org/schemas/sound/tas2780.yaml#" -$schema: "http://devicetree.org/meta-schemas/core.yaml#" - -title: Texas Instruments TAS2780 Smart PA - -maintainers: - - Raphael Xu <raphael-xu@ti.com> - -description: | - The TAS2780 is a mono, digital input Class-D audio amplifier optimized for - efficiently driving high peak power into small loudspeakers. - Integrated speaker voltage and current sense provides for - real time monitoring of loudspeaker behavior. - -properties: - compatible: - enum: - - ti,tas2780 - - reg: - description: - I2C address of the device can be between 0x38 to 0x3f. - minimum: 0x38 - maximum: 0x3f - - reset-gpios: - description: GPIO used to reset the device. - maxItems: 1 - - interrupts: - maxItems: 1 - - ti,imon-slot-no: - description: TDM TX current sense time slot. - $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0 - maximum: 3 - - ti,vmon-slot-no: - description: TDM TX voltage sense time slot. - $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0 - maximum: 3 - - '#sound-dai-cells': - const: 1 - -required: - - compatible - - reg - -additionalProperties: false - -examples: - - | - #include <dt-bindings/gpio/gpio.h> - i2c0 { - #address-cells = <1>; - #size-cells = <0>; - codec: codec@38 { - compatible = "ti,tas2780"; - reg = <0x38>; - #sound-dai-cells = <1>; - interrupts = <14>; - reset-gpios = <&gpio1 15 0>; - ti,imon-slot-no = <0>; - ti,vmon-slot-no = <2>; - }; - }; - -...
remove tas2780 Signed-off-by: Raphael-Xu <13691752556@139.com> --- .../devicetree/bindings/sound/tas2780.yaml | 75 ------------------- 1 file changed, 75 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml