diff mbox series

[v3,1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

Message ID 20220720063924.1412799-1-alexander.stein@ew.tq-group.com (mailing list archive)
State Accepted
Commit 5030a9a03f0107f645772450bcba521b2ec19a51
Delegated to: Netdev Maintainers
Headers show
Series [v3,1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Alexander Stein July 20, 2022, 6:39 a.m. UTC
These properties are inherited from ethernet-controller.yaml.
This fixes the dt_binding_check warning:
imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v3:
* Use nvmem-cells/nvmem-cell-names properties from ethernet-controller.yaml
* Set unevaluatedProperties instead of additionalProperties

Changes in v2:
* Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)

 Documentation/devicetree/bindings/net/fsl,fec.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) July 25, 2022, 10:18 p.m. UTC | #1
On Wed, 20 Jul 2022 08:39:24 +0200, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v3:
> * Use nvmem-cells/nvmem-cell-names properties from ethernet-controller.yaml
> * Set unevaluatedProperties instead of additionalProperties
> 
> Changes in v2:
> * Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)
> 
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
patchwork-bot+netdevbpf@kernel.org July 26, 2022, 1:10 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 20 Jul 2022 08:39:24 +0200 you wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> [...]

Here is the summary with links:
  - [v3,1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
    https://git.kernel.org/netdev/net-next/c/5030a9a03f01

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index daa2f79a294f..85a8d8fb6b8f 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -121,6 +121,10 @@  properties:
 
   mac-address: true
 
+  nvmem-cells: true
+
+  nvmem-cell-names: true
+
   tx-internal-delay-ps:
     enum: [0, 2000]
 
@@ -213,7 +217,7 @@  required:
 # least undocumented properties. However, PHY may have a deprecated option to
 # place PHY OF properties in the MAC node, such as Micrel PHY, and we can find
 # these boards which is based on i.MX6QDL.
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |