diff mbox series

ASoC: amd: acp: uninitialized variable in i2s_irq_handler()

Message ID YuFANcpt9Z8X9L5n@kili (mailing list archive)
State New, archived
Headers show
Series ASoC: amd: acp: uninitialized variable in i2s_irq_handler() | expand

Commit Message

Dan Carpenter July 27, 2022, 1:40 p.m. UTC 
The "ext_intr_stat1" is used without being initialized.

Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/amd/acp/acp-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown July 27, 2022, 2:15 p.m. UTC | #1 
On Wed, Jul 27, 2022 at 04:40:05PM +0300, Dan Carpenter wrote:
> The "ext_intr_stat1" is used without being initialized.

Someone submitted a patch for this yesterday.
diff mbox series

Patch

diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 10730d33c3b0..f561d39b33e2 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -100,7 +100,7 @@  static irqreturn_t i2s_irq_handler(int irq, void *data)
 		return IRQ_NONE;
 
 	if (adata->rsrc->no_of_ctrls == 2)
-		ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
+		ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
 
 	ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));