diff mbox series

[net,v2,2/5] octeontx2-af: suppress external profile loading warning

Message ID 1658844682-12913-3-git-send-email-sbhatta@marvell.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Octeontx2 AF driver fixes for NPC | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 2 blamed authors not CCed: george.cherian@marvell.com skardach@marvell.com; 6 maintainers not CCed: george.cherian@marvell.com gakula@marvell.com jerinj@marvell.com skardach@marvell.com lcherian@marvell.com hkelam@marvell.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Subbaraya Sundeep July 26, 2022, 2:11 p.m. UTC 
From: Harman Kalra <hkalra@marvell.com>

The packet parser profile supplied as firmware may not
be present all the time and default profile is used mostly.
Hence suppress firmware loading warning from kernel due to
absence of firmware in kernel image.

Fixes: 3a7244152f9c ("octeontx2-af: add support for custom KPU entries")
Signed-off-by: Harman Kalra <hkalra@marvell.com>
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski July 28, 2022, 2:41 a.m. UTC | #1 
On Tue, 26 Jul 2022 19:41:19 +0530 Subbaraya Sundeep wrote:
> -	if (!request_firmware(&fw, kpu_profile, rvu->dev)) {
> +	if (!firmware_request_nowarn(&fw, kpu_profile, rvu->dev)) {

Consider switching to request_firmware_direct() in net-next.
I doubt you need the sysfs fallback, I think udev dropped 
the support for it.
Jakub Kicinski July 28, 2022, 2:51 a.m. UTC | #2 
On Wed, 27 Jul 2022 19:41:20 -0700 Jakub Kicinski wrote:
> On Tue, 26 Jul 2022 19:41:19 +0530 Subbaraya Sundeep wrote:
> > -	if (!request_firmware(&fw, kpu_profile, rvu->dev)) {
> > +	if (!firmware_request_nowarn(&fw, kpu_profile, rvu->dev)) {  
> 
> Consider switching to request_firmware_direct() in net-next.
> I doubt you need the sysfs fallback, I think udev dropped 
> the support for it.

Well, the next patch needs work, so perhaps do it in v3?
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
index 3d99cb9..9404f86 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
@@ -1650,7 +1650,7 @@  static void npc_load_kpu_profile(struct rvu *rvu)
 	 * Firmware database method.
 	 * Default KPU profile.
 	 */
-	if (!request_firmware(&fw, kpu_profile, rvu->dev)) {
+	if (!firmware_request_nowarn(&fw, kpu_profile, rvu->dev)) {
 		dev_info(rvu->dev, "Loading KPU profile from firmware: %s\n",
 			 kpu_profile);
 		rvu->kpu_fwdata = kzalloc(fw->size, GFP_KERNEL);