| Message ID | 20220729063208.16799-7-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add driver nodes for MT8195 SoC | expand |
On Fri, 29 Jul 2022 14:31:54 +0800, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > --- > .../bindings/mfd/mediatek,mt8195-scpsys.yaml | 67 +++++++++++++++++++ > .../power/mediatek,power-controller.yaml | 2 +- > 2 files changed, 68 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On 29/07/2022 08:31, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Thank you for your patch. There is something to discuss/improve. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/mt8195-clk.h> > + #include <dt-bindings/power/mt8195-power.h> > + > + syscon@10006000 { > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > + reg = <0x10006000 0x100>; > + > + spm: power-controller { > + compatible = "mediatek,mt8195-power-controller"; > + #address-cells = <1>; > + #size-cells = <0>; > + #power-domain-cells = <1>; > + > + /* sample of power domain nodes */ > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>; Wrong indentation. Best regards, Krzysztof
On Tue, 2022-08-02 at 10:58 +0200, Krzysztof Kozlowski wrote: > On 29/07/2022 08:31, Tinghan Shen wrote: > > The System Control Processor System (SCPSYS) has several power > > management related tasks in the system. Add the bindings for it. > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > Thank you for your patch. There is something to discuss/improve. > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/mt8195-clk.h> > > + #include <dt-bindings/power/mt8195-power.h> > > + > > + syscon@10006000 { > > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > > + reg = <0x10006000 0x100>; > > + > > + spm: power-controller { > > + compatible = "mediatek,mt8195-power-controller"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #power-domain-cells = <1>; > > + > > + /* sample of power domain nodes */ > > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > > + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>; > > Wrong indentation. I missed these lines... I'll update in the next version. Best regards, TingHna
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml new file mode 100644 index 0000000000000..600caeb99e020 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek System Control Processor System + +maintainers: + - MandyJH Liu <mandyjh.liu@mediatek.com> + +description: + MediaTek System Control Processor System (SCPSYS) has several + power management tasks. The tasks include MTCMOS power + domain control, thermal measurement, DVFS, etc. + +properties: + compatible: + items: + - enum: + - mediatek,mt8167-scpsys + - mediatek,mt8173-scpsys + - mediatek,mt8183-scpsys + - mediatek,mt8192-scpsys + - mediatek,mt8195-scpsys + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + power-controller: + $ref: /schemas/power/mediatek,power-controller.yaml# + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8195-clk.h> + #include <dt-bindings/power/mt8195-power.h> + + syscon@10006000 { + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; + reg = <0x10006000 0x100>; + + spm: power-controller { + compatible = "mediatek,mt8195-power-controller"; + #address-cells = <1>; + #size-cells = <0>; + #power-domain-cells = <1>; + + /* sample of power domain nodes */ + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>; + #power-domain-cells = <0>; + }; + + power-domain@MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY { + reg = <MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>; + #power-domain-cells = <0>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml index 03b7f6aa591d4..605ec7ab5f633 100644 --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml @@ -135,7 +135,7 @@ examples: #size-cells = <2>; scpsys: syscon@10006000 { - compatible = "syscon", "simple-mfd"; + compatible = "mediatek,mt8173-scpsys", "syscon", "simple-mfd"; reg = <0 0x10006000 0 0x1000>; spm: power-controller {
The System Control Processor System (SCPSYS) has several power management related tasks in the system. Add the bindings for it. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> --- .../bindings/mfd/mediatek,mt8195-scpsys.yaml | 67 +++++++++++++++++++ .../power/mediatek,power-controller.yaml | 2 +- 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml