| Message ID | 20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Analog TV Improvements | expand |
Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector *connector) return i; } -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, - struct drm_display_mode *mode) -{ - /* TODO */ - return MODE_OK; -} - static const struct drm_connector_helper_funcs sun4i_tv_comp_connector_helper_funcs = { .get_modes = sun4i_tv_comp_get_modes, - .mode_valid = sun4i_tv_comp_mode_valid, }; static void
The mode_valid implementation is pretty much a nop, let's remove it. Signed-off-by: Maxime Ripard <maxime@cerno.tech>