mbox series

[GIT,PULL] Smack patches for v6.0

Message ID 827a0fe0-03a3-b5ca-db34-daff17095b8f@schaufler-ca.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [GIT,PULL] Smack patches for v6.0 | expand

Pull-request

https://github.com/cschaufler/smack-next tags/Smack-for-6.0

Message

Casey Schaufler Aug. 1, 2022, 8:13 p.m. UTC
Hello Linus,

Here is the Smack pull request for v6.0.

There are two minor code clean-ups. One removes a touch of
dead code and the other replaces an instance of kzalloc + strncpy
with kstrndup. The changes have been in next and pass all tests.
Thank you.

The following changes since commit f2906aa863381afb0015a9eb7fefad885d4e5a56:

  Linux 5.19-rc1 (2022-06-05 17:18:54 -0700)

are available in the Git repository at:

  https://github.com/cschaufler/smack-next tags/Smack-for-6.0

for you to fetch changes up to aa16fb4b9e7e1057008d999138e7ae68a40bf167:

  smack: Remove the redundant lsm_inode_alloc (2022-08-01 11:26:09 -0700)

----------------------------------------------------------------
Two minor code clean-ups for Smack.

----------------------------------------------------------------
GONG, Ruiqi (1):
      smack: Replace kzalloc + strncpy with kstrndup

Xiu Jianfeng (1):
      smack: Remove the redundant lsm_inode_alloc

 security/smack/smack_access.c | 7 ++-----
 security/smack/smack_lsm.c    | 7 -------
 2 files changed, 2 insertions(+), 12 deletions(-)

Comments

Linus Torvalds Aug. 2, 2022, 10:11 p.m. UTC | #1
On Mon, Aug 1, 2022 at 1:13 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> There are two minor code clean-ups. One removes a touch of
> dead code and the other replaces an instance of kzalloc + strncpy
> with kstrndup.

Hmm. That second one looks like it really should have just used
"kmemdup()" (and a zero termination) instead, since it has already
done all the string length calculations.

Oh well. I guess the strndup() works too, but it seems kind of odd to
do a strnlen() there when you have literally limited 'len' to smaller
than the string you are going to duplicate.

                   Linus
pr-tracker-bot@kernel.org Aug. 2, 2022, 10:29 p.m. UTC | #2
The pull request you sent on Mon, 1 Aug 2022 13:13:20 -0700:

> https://github.com/cschaufler/smack-next tags/Smack-for-6.0

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ea7099d5229c0fe9f9302b03a246e15e78b87011

Thank you!