| Message ID | 20220804220602.477589-4-sean.anderson@seco.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: Add support for Lynx 10G SerDes | expand |
On 05/08/2022 00:05, Sean Anderson wrote: > This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used > witn assigned-clock* to specify a particular frequency to use. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> > --- > > Changes in v4: > - New > > include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h > > diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h > new file mode 100644 > index 000000000000..f5b955658106 > --- /dev/null > +++ b/include/dt-bindings/clock/fsl,lynx-10g.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ This should be dual license. > +/* > + * Copyright (C) 2022 Sean Anderson <sean.anderson@seco.com> It's confusing to see personal copyrights with company email. Either the copyright is attributed to your employer or to you. If to you, use private email. > + */ > + > +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H > +#define __DT_BINDINGS_CLK_LYNX_10G_H > + > +#define LYNX10G_CLKS_PER_PLL 2 > + > +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) > +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) These do not look like proper IDs for clocks for bindings. Numbering starts from 0 or 1 and any "a" needs to be clearly explained. What do you bind here? > + > +#endif /* __DT_BINDINGS_CLK_LYNX_10G_H */ Best regards, Krzysztof
On 8/5/22 2:53 AM, Krzysztof Kozlowski wrote: > On 05/08/2022 00:05, Sean Anderson wrote: >> This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used >> witn assigned-clock* to specify a particular frequency to use. >> >> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >> --- >> >> Changes in v4: >> - New >> >> include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h >> >> diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h >> new file mode 100644 >> index 000000000000..f5b955658106 >> --- /dev/null >> +++ b/include/dt-bindings/clock/fsl,lynx-10g.h >> @@ -0,0 +1,14 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > This should be dual license. This is just matching what the majority (263 out of 326) clock dt-bindings headers do. >> +/* >> + * Copyright (C) 2022 Sean Anderson <sean.anderson@seco.com> > > It's confusing to see personal copyrights with company email. Either the > copyright is attributed to your employer or to you. If to you, use > private email. I hold the copyright, and I would like inquiries to be directed to my work email (as I don't have this hardware at home). >> + */ >> + >> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H >> +#define __DT_BINDINGS_CLK_LYNX_10G_H >> + >> +#define LYNX10G_CLKS_PER_PLL 2 >> + >> +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) >> +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) > > These do not look like proper IDs for clocks for bindings. Numbering > starts from 0 or 1 and any "a" needs to be clearly explained. What do > you bind here? This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc. This matches the notation used in the reference manual. Although for convenience, this driver considers the PLLs to start at 0 instead of 1. --Sean
On 05/08/2022 17:17, Sean Anderson wrote: > > > On 8/5/22 2:53 AM, Krzysztof Kozlowski wrote: >> On 05/08/2022 00:05, Sean Anderson wrote: >>> This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used >>> witn assigned-clock* to specify a particular frequency to use. >>> >>> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >>> --- >>> >>> Changes in v4: >>> - New >>> >>> include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h >>> >>> diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h >>> new file mode 100644 >>> index 000000000000..f5b955658106 >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/fsl,lynx-10g.h >>> @@ -0,0 +1,14 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >> >> This should be dual license. > > This is just matching what the majority (263 out of 326) clock dt-bindings headers do. Then please license it just like bindings, so dual license with BSD. > >>> +/* >>> + * Copyright (C) 2022 Sean Anderson <sean.anderson@seco.com> >> >> It's confusing to see personal copyrights with company email. Either the >> copyright is attributed to your employer or to you. If to you, use >> private email. > > I hold the copyright, and I would like inquiries to be directed to my work > email (as I don't have this hardware at home). OK, I guess I won't be the only one confused :). This entry here is not parsed for any tools and only sometimes people look at it. The questions are directed via entry in maintainers file or via git history, so you can put company email just there. > >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H >>> +#define __DT_BINDINGS_CLK_LYNX_10G_H >>> + >>> +#define LYNX10G_CLKS_PER_PLL 2 >>> + >>> +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) >>> +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) >> >> These do not look like proper IDs for clocks for bindings. Numbering >> starts from 0 or 1 and any "a" needs to be clearly explained. What do >> you bind here? > > This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc. > This matches the notation used in the reference manual. This is a file for bindings, not for storing register values. There is no single need to store register values (offsets, indexes) as bindings as it is not appropriate. Therefore if you do not use it as an ID, just remove the bindings header. > Although for > convenience, this driver considers the PLLs to start at 0 instead of 1. Best regards, Krzysztof
On 8/8/22 1:46 AM, Krzysztof Kozlowski wrote: > On 05/08/2022 17:17, Sean Anderson wrote: >> >> >> On 8/5/22 2:53 AM, Krzysztof Kozlowski wrote: >>> On 05/08/2022 00:05, Sean Anderson wrote: >>>> This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used >>>> witn assigned-clock* to specify a particular frequency to use. >>>> >>>> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >>>> --- >>>> >>>> Changes in v4: >>>> - New >>>> >>>> include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h >>>> >>>> diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h >>>> new file mode 100644 >>>> index 000000000000..f5b955658106 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/clock/fsl,lynx-10g.h >>>> @@ -0,0 +1,14 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> >>> This should be dual license. >> >> This is just matching what the majority (263 out of 326) clock dt-bindings headers do. > > Then please license it just like bindings, so dual license with BSD. OK >> >>>> +/* >>>> + * Copyright (C) 2022 Sean Anderson <sean.anderson@seco.com> >>> >>> It's confusing to see personal copyrights with company email. Either the >>> copyright is attributed to your employer or to you. If to you, use >>> private email. >> >> I hold the copyright, and I would like inquiries to be directed to my work >> email (as I don't have this hardware at home). > > OK, I guess I won't be the only one confused :). You're the first person to comment on this. > This entry here is not > parsed for any tools and only sometimes people look at it. The questions > are directed via entry in maintainers file or via git history, so you > can put company email just there. As I understand it, the email is simply informative. There are literally hundreds of examples of mixing a "personal" copyright with a company email. It is easy to find if you grep. If you are so opposed to it, then I will remove the email and simply use my name. >> >>>> + */ >>>> + >>>> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H >>>> +#define __DT_BINDINGS_CLK_LYNX_10G_H >>>> + >>>> +#define LYNX10G_CLKS_PER_PLL 2 >>>> + >>>> +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) >>>> +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) >>> >>> These do not look like proper IDs for clocks for bindings. Numbering >>> starts from 0 or 1 and any "a" needs to be clearly explained. What do >>> you bind here? >> >> This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc. >> This matches the notation used in the reference manual. > > This is a file for bindings, not for storing register values. There is > no single need to store register values (offsets, indexes) as bindings > as it is not appropriate. Therefore if you do not use it as an ID, just > remove the bindings header. This *is* just for IDs, as stated in the commit message. The above example was only to illustrate that the clock controlled via the PLL1RSTCTL register (among others) would have an ID of LYNX10G_PLLa(0). If you doubt it, review the driver. --Sean
On 08/08/2022 18:16, Sean Anderson wrote: > >> This entry here is not >> parsed for any tools and only sometimes people look at it. The questions >> are directed via entry in maintainers file or via git history, so you >> can put company email just there. > > As I understand it, the email is simply informative. There are literally > hundreds of examples of mixing a "personal" copyright with a company email. > It is easy to find if you grep. If you are so opposed to it, then I will > remove the email and simply use my name. No, no problem for me. > >>> >>>>> + */ >>>>> + >>>>> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H >>>>> +#define __DT_BINDINGS_CLK_LYNX_10G_H >>>>> + >>>>> +#define LYNX10G_CLKS_PER_PLL 2 >>>>> + >>>>> +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) >>>>> +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) >>>> >>>> These do not look like proper IDs for clocks for bindings. Numbering >>>> starts from 0 or 1 and any "a" needs to be clearly explained. What do >>>> you bind here? >>> >>> This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc. >>> This matches the notation used in the reference manual. >> >> This is a file for bindings, not for storing register values. There is >> no single need to store register values (offsets, indexes) as bindings >> as it is not appropriate. Therefore if you do not use it as an ID, just >> remove the bindings header. > > This *is* just for IDs, as stated in the commit message. The above example > was only to illustrate that the clock controlled via the PLL1RSTCTL register > (among others) would have an ID of LYNX10G_PLLa(0). > > If you doubt it, review the driver. Indeed, thanks. Except the driver, where is the DTS user of these bindings? It's neither in bindings example, nor in the DTS patches. Best regards, Krzysztof
On 8/9/22 1:21 AM, Krzysztof Kozlowski wrote: > On 08/08/2022 18:16, Sean Anderson wrote: >> >>> This entry here is not >>> parsed for any tools and only sometimes people look at it. The questions >>> are directed via entry in maintainers file or via git history, so you >>> can put company email just there. >> >> As I understand it, the email is simply informative. There are literally >> hundreds of examples of mixing a "personal" copyright with a company email. >> It is easy to find if you grep. If you are so opposed to it, then I will >> remove the email and simply use my name. > > No, no problem for me. > >> >>>> >>>>>> + */ >>>>>> + >>>>>> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H >>>>>> +#define __DT_BINDINGS_CLK_LYNX_10G_H >>>>>> + >>>>>> +#define LYNX10G_CLKS_PER_PLL 2 >>>>>> + >>>>>> +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) >>>>>> +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) >>>>> >>>>> These do not look like proper IDs for clocks for bindings. Numbering >>>>> starts from 0 or 1 and any "a" needs to be clearly explained. What do >>>>> you bind here? >>>> >>>> This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc. >>>> This matches the notation used in the reference manual. >>> >>> This is a file for bindings, not for storing register values. There is >>> no single need to store register values (offsets, indexes) as bindings >>> as it is not appropriate. Therefore if you do not use it as an ID, just >>> remove the bindings header. >> >> This *is* just for IDs, as stated in the commit message. The above example >> was only to illustrate that the clock controlled via the PLL1RSTCTL register >> (among others) would have an ID of LYNX10G_PLLa(0). >> >> If you doubt it, review the driver. > > Indeed, thanks. Except the driver, where is the DTS user of these > bindings? It's neither in bindings example, nor in the DTS patches. The primary purpose is to allow using assigned-clocks. The reference manual for the processor may specify that certain PLLs must be used with a certain rate when in some configuration (this is not necessary for the LS1046A or LS1088A, but there are restrictions for e.g. the LS1043A). Using assigned-clock-rates allows specifying which PLL is to be used at which rate (especially if it differs from the bootloader). Of course, the driver could adjust this later, but it will always use the configured PLL rate before reconfiguring anything. --Sean
diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h new file mode 100644 index 000000000000..f5b955658106 --- /dev/null +++ b/include/dt-bindings/clock/fsl,lynx-10g.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2022 Sean Anderson <sean.anderson@seco.com> + */ + +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H +#define __DT_BINDINGS_CLK_LYNX_10G_H + +#define LYNX10G_CLKS_PER_PLL 2 + +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) + +#endif /* __DT_BINDINGS_CLK_LYNX_10G_H */
This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used witn assigned-clock* to specify a particular frequency to use. Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- Changes in v4: - New include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h