mbox series

[kvmtool,0/4] Makefile and virtio fixes

Message ID 20220722141731.64039-1-jean-philippe@linaro.org (mailing list archive)
Headers show
Series Makefile and virtio fixes | expand

Message

Jean-Philippe Brucker July 22, 2022, 2:17 p.m. UTC 
A few small fixes for kvmtool:

Patch 1 fixes an annoying issue when building kvmtool after updating
without a make clean.

Patch 2 enables passing ARCH=i386 and ARCH=x86_64.

Patch 3 fixes an issue with INTx on modern virtio-pci. That code was
written when INTx were edge-triggered, but they are now level-triggered.

Patch 4 fixes an uninitialized allocation error.

Jean-Philippe Brucker (4):
  Makefile: Add missing build dependencies
  Makefile: Fix ARCH override
  virtio/pci: Deassert IRQ line on ISR read
  virtio/rng: Zero-initialize the device

 Makefile            | 7 ++++---
 virtio/pci-modern.c | 5 +----
 virtio/rng.c        | 2 +-
 3 files changed, 6 insertions(+), 8 deletions(-)

Comments

Will Deacon Aug. 4, 2022, 3:02 p.m. UTC | #1 
On Fri, 22 Jul 2022 15:17:28 +0100, Jean-Philippe Brucker wrote:
> A few small fixes for kvmtool:
> 
> Patch 1 fixes an annoying issue when building kvmtool after updating
> without a make clean.
> 
> Patch 2 enables passing ARCH=i386 and ARCH=x86_64.
> 
> [...]

I wasn't sure whether you were going to respin patch 2 based on Alexandru's
comment, but I actually ran into the legacy IRQ issue so I went ahead and
applied the series. I can, of course, queue extra stuff on top if you like!

Applied to kvmtool (master), thanks!

[1/4] Makefile: Add missing build dependencies
      https://git.kernel.org/will/kvmtool/c/3863f34bd767
[2/4] Makefile: Fix ARCH override
      https://git.kernel.org/will/kvmtool/c/ae22ac7a81e5
[3/4] virtio/pci: Deassert IRQ line on ISR read
      https://git.kernel.org/will/kvmtool/c/fe2182731b72
[4/4] virtio/rng: Zero-initialize the device
      https://git.kernel.org/will/kvmtool/c/6c88c26f701f

Cheers,
Jean-Philippe Brucker Aug. 9, 2022, 10:05 a.m. UTC | #2 
On Thu, Aug 04, 2022 at 04:02:27PM +0100, Will Deacon wrote:
> On Fri, 22 Jul 2022 15:17:28 +0100, Jean-Philippe Brucker wrote:
> > A few small fixes for kvmtool:
> > 
> > Patch 1 fixes an annoying issue when building kvmtool after updating
> > without a make clean.
> > 
> > Patch 2 enables passing ARCH=i386 and ARCH=x86_64.
> > 
> > [...]
> 
> I wasn't sure whether you were going to respin patch 2 based on Alexandru's
> comment, but I actually ran into the legacy IRQ issue so I went ahead and
> applied the series. I can, of course, queue extra stuff on top if you like!

Right I was away, thanks for picking those up. I don't think patch 2 needs
any change but I may send an optimization for patch 1

Thanks,
Jean