| Message ID | 20220804021553.14867-3-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add driver nodes for MT8195 SoC | expand |
On 04/08/2022 04:15, Tinghan Shen wrote: > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > matches the 'else' conditions for gen2 HW without gals. > > Rewrite the 'else' condition to specifically identify the compatibles > that utilizing gen2 HW without gals. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> Unfortunately, your patches got corrupted. Best regards, Krzysztof
Hi Krzysztof, On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote: > On 04/08/2022 04:15, Tinghan Shen wrote: > > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > > matches the 'else' conditions for gen2 HW without gals. > > > > Rewrite the 'else' condition to specifically identify the compatibles > > that utilizing gen2 HW without gals. > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno > > <angelogioacchino.delregno@collabora.com> > > Unfortunately, your patches got corrupted. > > > Best regards, > Krzysztof Do you mean rebase to the latest linux-next? I'll rebase in the next version, thanks! Best regards, TingHan
On 09/08/2022 14:01, Tinghan Shen wrote: > Hi Krzysztof, > > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote: >> On 04/08/2022 04:15, Tinghan Shen wrote: >>> >>> It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly >>> matches the 'else' conditions for gen2 HW without gals. >>> >>> Rewrite the 'else' condition to specifically identify the compatibles >>> that utilizing gen2 HW without gals. >>> >>> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> >>> Reviewed-by: AngeloGioacchino Del Regno >>> <angelogioacchino.delregno@collabora.com> >> >> Unfortunately, your patches got corrupted. >> >> >> Best regards, >> Krzysztof > > Do you mean rebase to the latest linux-next? > I'll rebase in the next version, thanks! > No, I mean look at the line above. And many other lines. That's not a proper patch file. It's not my email client. Lore reports the same. Best regards, Krzysztof
On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote: > Hi Krzysztof, > > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote: > > On 04/08/2022 04:15, Tinghan Shen wrote: > > > > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > > > matches the 'else' conditions for gen2 HW without gals. > > > > > > Rewrite the 'else' condition to specifically identify the compatibles > > > that utilizing gen2 HW without gals. > > > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > > Reviewed-by: AngeloGioacchino Del Regno > > > <angelogioacchino.delregno@collabora.com> > > > > Unfortunately, your patches got corrupted. > > > > > > Best regards, > > Krzysztof > > Do you mean rebase to the latest linux-next? > I'll rebase in the next version, thanks! Hi TingHan, the issue is that some line wrapping happened on your patches, which broke tags and also the diffs themselves (it's very obvious on patch 3). So you need to sort out your setup so that no longer happens, and resend the patch. Thanks, Nícolas
On Tue, 2022-08-09 at 09:53 -0400, Nícolas F. R. A. Prado wrote: > On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote: > > Hi Krzysztof, > > > > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote: > > > On 04/08/2022 04:15, Tinghan Shen wrote: > > > > > > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > > > > matches the 'else' conditions for gen2 HW without gals. > > > > > > > > Rewrite the 'else' condition to specifically identify the compatibles > > > > that utilizing gen2 HW without gals. > > > > > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > > > Reviewed-by: AngeloGioacchino Del Regno > > > > <angelogioacchino.delregno@collabora.com> > > > > > > Unfortunately, your patches got corrupted. > > > > > > > > > Best regards, > > > Krzysztof > > > > Do you mean rebase to the latest linux-next? > > I'll rebase in the next version, thanks! > > Hi TingHan, > > the issue is that some line wrapping happened on your patches, which broke tags > and also the diffs themselves (it's very obvious on patch 3). So you need to > sort out your setup so that no longer happens, and resend the patch. > > Thanks, > Nícolas I see. I'll send the next version after fix the weired wrapping... Thank you. Best regards, TingHan
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml index 71bc5cefb49cf..4f5dd0a20109e 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml @@ -144,7 +144,16 @@ allOf: - const: gals0 - const: gals1 - else: # for gen2 HW that don't have gals + - if: # for gen2 HW that don't have gals + properties: + compatible: + enum: + - mediatek,mt2712-smi-common + - mediatek,mt6795-smi-common + - mediatek,mt8167-smi-common + - mediatek,mt8173-smi-common + + then: properties: clocks: minItems: 2
The max clock items for the dts node with compatible 'mediatek,mt8195-smi-sub-common' should be 3. However, the dtbs_check of such node will get following message, arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly matches the 'else' conditions for gen2 HW without gals. Rewrite the 'else' condition to specifically identify the compatibles that utilizing gen2 HW without gals. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../memory-controllers/mediatek,smi-common.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)