[v2,1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings

Commit Message

Shenwei Wang Aug. 9, 2022, 2:31 p.m. UTC

Add binding document for the imx-scu gpio driver.

Signed-off-by: Shenwei Wang <[e-mail]>
---
 .../bindings/gpio/fsl,imx8-scu-gpio.yaml      | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml

Comments

Krzysztof Kozlowski Aug. 9, 2022, 4:05 p.m. UTC | #1

On 09/08/2022 17:31, Shenwei Wang wrote:
> Add binding document for the imx-scu gpio driver.
> 
> Signed-off-by: Shenwei Wang <[e-mail]>
> ---
>  .../bindings/gpio/fsl,imx8-scu-gpio.yaml      | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
> new file mode 100644
> index 000000000000..4cbe3108a612
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO driver over IMX SCU firmware API
> +
> +maintainers:
> +  - Shenwei Wang <[e-mail]>
> +
> +description: |
> +  This module provides the standard interface to control the
> +  resource pins in SCU domain on i.MX8 platforms.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8-scu-gpio

This should be rather a specific imx8 chip. See other imx8 SCU bindings.
Strictly speaking there is no "imx8" SoC and compatible should be
derived from SoC.



Best regards,
Krzysztof

Shenwei Wang Aug. 9, 2022, 7:10 p.m. UTC | #2

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Tuesday, August 9, 2022 11:05 AM
> To: Shenwei Wang <[e-mail]>; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; dl-linux-imx <[e-mail]>
> Cc: [e-mail]; [e-mail]; linux-
> [e-mail]; [e-mail]; [e-mail]
> Subject: [EXT] Re: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx8-scu-gpio
> 
> This should be rather a specific imx8 chip. See other imx8 SCU bindings.
> Strictly speaking there is no "imx8" SoC and compatible should be derived from
> SoC.

Make sense. Thank you very much for the comments.

Regards
Shenwei

> 
> 
> 
> Best regards,
> Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
new file mode 100644
index 000000000000..4cbe3108a612
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
@@ -0,0 +1,39 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO driver over IMX SCU firmware API
+
+maintainers:
+  - Shenwei Wang <[e-mail]>
+
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8-scu-gpio
+
+  "#gpio-cells":
+    const: 2
+
+  gpio-controller: true
+
+required:
+  - compatible
+  - "#gpio-cells"
+  - gpio-controller
+
+additionalProperties: false
+
+examples:
+  - |
+    gpio0: gpio {
+        compatible = "fsl,imx8-scu-gpio";
+        gpio-controller;
+        #gpio-cells = <2>;
+    };