[v7,0/9] Clean-up stale/unused hci_request.c code

Message

Brian Gix Aug. 5, 2022, 11:42 p.m. UTC

This will be a growing patch-set of conversions and dead-code removal
towards the goal of retiring hci_request.c

The patch sets will be split amoung the work queues and delayed work
queues as initialized in hci_request_setup(), with the ultimate goal of
eliminating hci_request.c entirely.

v2: Published

v3: Continuing work.  This does include one conversion
(SCO configure_datapath) that has been tested with mgmt-tester and
sco-tester, but has not been tested with a controller with an
off-loadable codec.

v4: Clean-up checkpatch warnings.

v5: Remove remaining procedures from hci_request.c/h. Not that other
entities (notably amp.c, hci_event.c and hci_core.c) are still using
the hci_request mechanism, however, the mgmt-tester unit test only
currently execute opcode 0x1408 - HCI_OP_READ_ENC_KEY_SIZE during normal
testing.

v6: Fix CI reported errors, and recoded hci_abort_conn for optional sync
queue usage to fix some L2CAP test cases.

v7: Delete and rebase to remove conflicting interleave scan clean-up.
Will be done using work Luiz has been working on.

Brian Gix (9):
  Bluetooth: Convert le_scan_disable timeout to hci_sync
  Bluetooth: Rework le_scan_restart for hci_sync
  Bluetooth: Delete unused hci_req_stop_discovery()
  Bluetooth: Convert SCO configure_datapath to hci_sync
  Bluetooth: Move Adv Instance timer to hci_sync
  Bluetooth: Delete unreferenced hci_request code
  Bluetooth: move hci_get_random_address() to hci_sync
  Bluetooth: convert hci_update_adv_data to hci_sync
  Bluetooth: Convert hci_abort_conn to hci_sync

 include/net/bluetooth/hci_sync.h |   10 +-
 net/bluetooth/hci_conn.c         |   92 +-
 net/bluetooth/hci_core.c         |    2 +-
 net/bluetooth/hci_event.c        |    2 +-
 net/bluetooth/hci_request.c      | 1650 +++---------------------------
 net/bluetooth/hci_request.h      |   53 -
 net/bluetooth/hci_sync.c         |  500 ++++++++-
 net/bluetooth/mgmt.c             |    7 +-
 8 files changed, 733 insertions(+), 1583 deletions(-)

Comments

[e-mail] Aug. 9, 2022, 10 p.m. UTC | #1

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Fri,  5 Aug 2022 16:42:27 -0700 you wrote:
> This will be a growing patch-set of conversions and dead-code removal
> towards the goal of retiring hci_request.c
> 
> The patch sets will be split amoung the work queues and delayed work
> queues as initialized in hci_request_setup(), with the ultimate goal of
> eliminating hci_request.c entirely.
> 
> [...]

Here is the summary with links:
  - [v7,1/9] Bluetooth: Convert le_scan_disable timeout to hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/2bf8edacd155
  - [v7,2/9] Bluetooth: Rework le_scan_restart for hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/89f043b2c6d5
  - [v7,3/9] Bluetooth: Delete unused hci_req_stop_discovery()
    https://git.kernel.org/bluetooth/bluetooth-next/c/eed7aab6c517
  - [v7,4/9] Bluetooth: Convert SCO configure_datapath to hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/71172654bff2
  - [v7,5/9] Bluetooth: Move Adv Instance timer to hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/8c59889a6b5c
  - [v7,6/9] Bluetooth: Delete unreferenced hci_request code
    https://git.kernel.org/bluetooth/bluetooth-next/c/3edf244f8c71
  - [v7,7/9] Bluetooth: move hci_get_random_address() to hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/c7eb26d1285c
  - [v7,8/9] Bluetooth: convert hci_update_adv_data to hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/9ec46ac996f5
  - [v7,9/9] Bluetooth: Convert hci_abort_conn to hci_sync
    (no matching commit)

You are awesome, thank you!