diff mbox series

fixup! media: dw100: Add i.MX8MP dw100 dewarper driver

Message ID 20220804122302.2218906-1-xavier.roumegue@oss.nxp.com (mailing list archive)
State New, archived
Headers show
Series fixup! media: dw100: Add i.MX8MP dw100 dewarper driver | expand

Commit Message

Xavier Roumegue (OSS) Aug. 4, 2022, 12:23 p.m. UTC
Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
---
 drivers/media/platform/nxp/dw100/dw100.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Nicolas Dufresne Aug. 16, 2022, 1:26 p.m. UTC | #1
Le jeudi 04 août 2022 à 14:23 +0200, Xavier Roumegue a écrit :

Perhaps you meant to use a Fixes tag rather then git --fixup feature here ?

> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> ---
>  drivers/media/platform/nxp/dw100/dw100.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index 651622f8ac8c..94518f0e486b 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -379,14 +379,12 @@ static void dw100_ctrl_dewarping_map_init(const struct v4l2_ctrl *ctrl,
>  	struct dw100_ctx *ctx =
>  		container_of(ctrl->handler, struct dw100_ctx, hdl);
>  
> -	u32 sw, sh, dw, dh, mw, mh, idx;
> +	u32 sw, sh, mw, mh, idx;
>  	u16 qx, qy, qdx, qdy, qsh, qsw;
>  	u32 *map = ctrl->p_cur.p_u32;
>  
>  	sw = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.width;
> -	dw = ctx->q_data[DW100_QUEUE_DST].pix_fmt.width;
>  	sh = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.height;
> -	dh = ctx->q_data[DW100_QUEUE_DST].pix_fmt.height;
>  
>  	mw = ctrl->dims[0];
>  	mh = ctrl->dims[1];
Hans Verkuil Aug. 16, 2022, 1:28 p.m. UTC | #2
On 16/08/2022 15:26, Nicolas Dufresne wrote:
> Le jeudi 04 août 2022 à 14:23 +0200, Xavier Roumegue a écrit :
> 
> Perhaps you meant to use a Fixes tag rather then git --fixup feature here ?

I squashed this in the patch adding this driver. No need for a fixes tag.

PR is pending.

Hans

> 
>> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
>> ---
>>  drivers/media/platform/nxp/dw100/dw100.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
>> index 651622f8ac8c..94518f0e486b 100644
>> --- a/drivers/media/platform/nxp/dw100/dw100.c
>> +++ b/drivers/media/platform/nxp/dw100/dw100.c
>> @@ -379,14 +379,12 @@ static void dw100_ctrl_dewarping_map_init(const struct v4l2_ctrl *ctrl,
>>  	struct dw100_ctx *ctx =
>>  		container_of(ctrl->handler, struct dw100_ctx, hdl);
>>  
>> -	u32 sw, sh, dw, dh, mw, mh, idx;
>> +	u32 sw, sh, mw, mh, idx;
>>  	u16 qx, qy, qdx, qdy, qsh, qsw;
>>  	u32 *map = ctrl->p_cur.p_u32;
>>  
>>  	sw = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.width;
>> -	dw = ctx->q_data[DW100_QUEUE_DST].pix_fmt.width;
>>  	sh = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.height;
>> -	dh = ctx->q_data[DW100_QUEUE_DST].pix_fmt.height;
>>  
>>  	mw = ctrl->dims[0];
>>  	mh = ctrl->dims[1];
>
diff mbox series

Patch

diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 651622f8ac8c..94518f0e486b 100644
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -379,14 +379,12 @@  static void dw100_ctrl_dewarping_map_init(const struct v4l2_ctrl *ctrl,
 	struct dw100_ctx *ctx =
 		container_of(ctrl->handler, struct dw100_ctx, hdl);
 
-	u32 sw, sh, dw, dh, mw, mh, idx;
+	u32 sw, sh, mw, mh, idx;
 	u16 qx, qy, qdx, qdy, qsh, qsw;
 	u32 *map = ctrl->p_cur.p_u32;
 
 	sw = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.width;
-	dw = ctx->q_data[DW100_QUEUE_DST].pix_fmt.width;
 	sh = ctx->q_data[DW100_QUEUE_SRC].pix_fmt.height;
-	dh = ctx->q_data[DW100_QUEUE_DST].pix_fmt.height;
 
 	mw = ctrl->dims[0];
 	mh = ctrl->dims[1];